doc: claim NODE_MODULE_VERSION=80 for Electron 9 #30052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@targos Happy to take whichever number but I feel as though this PR is gonna land first. Just lemme know which number you're ok with 👍 |
|
#30020 is going to land much later, you can have |
targos
approved these changes
Oct 22, 2019
BethGriggs
approved these changes
Oct 22, 2019
devnexen
approved these changes
Oct 22, 2019
lpinca
approved these changes
Oct 22, 2019
cjihrig
approved these changes
Oct 22, 2019
jasnell
approved these changes
Oct 26, 2019
targos
pushed a commit
that referenced
this pull request
Oct 27, 2019
PR-URL: #30052 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 3a90fcf |
targos
pushed a commit
that referenced
this pull request
Oct 28, 2019
PR-URL: #30052 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
So what does NODE_MODULE_VERSION corresponds to ? I used NodeJs 13.1.0 for building electron-edge-js , and it says that is NODE_MODULE_VERSION |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title, just claiming our next number