Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: find Python syntax errors in dependencies #30143

Closed
wants to merge 2 commits into from
Closed

build: find Python syntax errors in dependencies #30143

wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 27, 2019

As discussed in #30129 (comment), when we vendor in code, we own the Syntax Errors in that code. This PR adds a Travis CI test run that looks for syntax errors and undefined names in the Python code of our vendored dependencies. The .flake8 config file at the root of this repo puts blinders on the linting of our dependencies so this test disables that file before starting the linting.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 27, 2019
@cclauss cclauss mentioned this pull request Oct 27, 2019
Closed
4 tasks
@cclauss cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Oct 27, 2019
@cclauss cclauss mentioned this pull request Oct 27, 2019
Closed
This was referenced Oct 27, 2019
Closed
Closed
@Trott
Copy link
Member

Trott commented Oct 28, 2019

LIte CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4016/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 28, 2019
@cclauss
build: find Python syntax errors in dependencies
8444de8 
As discussed in #30129 (comment), when we vendor in code, we own the Syntax Errors in that code.  This PR adds The `.flake8` config file at the root of this repo puts blinders on the linting of our dependencies so this test disables that file before linting.
@cclauss
fixup: allow_failures until dependencies pass
c69a472
@cclauss cclauss force-pushed the flake8-the-entire-repo branch from 238e6e2 to c69a472 Compare October 31, 2019 16:32
@sam-github
Copy link
Contributor

lite ci:https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4024/

cclauss added a commit that referenced this pull request Oct 31, 2019
@cclauss
build: find Python syntax errors in dependencies
b23b8dc 
As discussed in
#30129 (comment), when
we vendor in code, we own the Syntax Errors in that code.  This PR adds
The `.flake8` config file at the root of this repo puts blinders on the
linting of our dependencies so this test disables that file before
linting.

fixup: allow_failures until dependencies pass

PR-URL: #30143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@cclauss
Copy link
Contributor Author

cclauss commented Oct 31, 2019

Landed in b23b8dc

@cclauss cclauss closed this Oct 31, 2019
@cclauss cclauss deleted the flake8-the-entire-repo branch October 31, 2019 20:56
targos pushed a commit that referenced this pull request Nov 5, 2019
@cclauss @targos
build: find Python syntax errors in dependencies
5469811 
As discussed in
#30129 (comment), when
we vendor in code, we own the Syntax Errors in that code.  This PR adds
The `.flake8` config file at the root of this repo puts blinders on the
linting of our dependencies so this test disables that file before
linting.

fixup: allow_failures until dependencies pass

PR-URL: #30143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@cclauss @targos
build: find Python syntax errors in dependencies
3de6522 
As discussed in
#30129 (comment), when
we vendor in code, we own the Syntax Errors in that code.  This PR adds
The `.flake8` config file at the root of this repo puts blinders on the
linting of our dependencies so this test disables that file before
linting.

fixup: allow_failures until dependencies pass

PR-URL: #30143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@cclauss @targos
build: find Python syntax errors in dependencies
59bf124 
As discussed in
#30129 (comment), when
we vendor in code, we own the Syntax Errors in that code.  This PR adds
The `.flake8` config file at the root of this repo puts blinders on the
linting of our dependencies so this test disables that file before
linting.

fixup: allow_failures until dependencies pass

PR-URL: #30143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@cclauss @targos
build: find Python syntax errors in dependencies
cd1cbce 
As discussed in
#30129 (comment), when
we vendor in code, we own the Syntax Errors in that code.  This PR adds
The `.flake8` config file at the root of this repo puts blinders on the
linting of our dependencies so this test disables that file before
linting.

fixup: allow_failures until dependencies pass

PR-URL: #30143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@cclauss @targos
build: find Python syntax errors in dependencies
c5d312f 
As discussed in
#30129 (comment), when
we vendor in code, we own the Syntax Errors in that code.  This PR adds
The `.flake8` config file at the root of this repo puts blinders on the
linting of our dependencies so this test disables that file before
linting.

fixup: allow_failures until dependencies pass

PR-URL: #30143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cclauss @Trott @sam-github @targos @cjihrig @gengjiawen @richardlau @nodejs-github-bot