Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve doc Http2Stream:Aborted #30179

Closed
wants to merge 1 commit into from
Closed

doc: improve doc Http2Stream:Aborted #30179

wants to merge 1 commit into from

Conversation

dev-script
Copy link
Contributor

@dev-script dev-script commented Oct 30, 2019 •
edited
Loading

Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Fixes: nodejs/help#877

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Oct 30, 2019
@dev-script dev-script changed the title docs: improve doc Http2Stream:Aborted doc: improve doc Http2Stream:Aborted Oct 30, 2019
@dev-script
doc: improve doc Http2Stream:Aborted
d27978b 
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Fixes: nodejs/help#877
@gireeshpunathil
Copy link
Member

@dev-313 - if you are planning to attack all of those pending http2 event arguments mentioned in the referenced issue, it may be a good idea to combine the rest into one single PR - easy to review, easy to manage.

@dev-script
Copy link
Contributor Author

Okay @gireeshpunathil . Thanks

@trivikr
Copy link
Member

trivikr commented Oct 31, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4023/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 31, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26252/

@gireeshpunathil
Copy link
Member

@nodejs/build - can you please review https://ci.nodejs.org/job/node-linter/3957/console and advise what is going on? does not look like a normal build failure to me.

@richardlau
Copy link
Member

richardlau commented Oct 31, 2019 •
edited
Loading

@nodejs/build - can you please review https://ci.nodejs.org/job/node-linter/3957/console and advise what is going on? does not look like a normal build failure to me.

@rvagg I think this is related to nodejs/build#2012 (comment).

The Pre-flight stage of https://ci.nodejs.org/job/node-linter/ calls https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh

sh "curl -L -s https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh -s | bash -xe"

which calls https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-diagnostics.sh
which tries to write to DIAGFILE=${HOME}/jenkins_diagnostics.txt and fails:

01:40:36  + curl https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-diagnostics.sh
01:40:36  + bash -ex -s before
01:40:36    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
01:40:36                                   Dload  Upload   Total   Spent    Left  Speed
01:40:37  
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   985  100   985    0     0   3315      0 --:--:-- --:--:-- --:--:--  3327
01:40:37  + set +x
01:40:37  bash: line 9: /jenkins_diagnostics.txt: Permission denied

suggesting ${HOME} is empty?

@rvagg
Copy link
Member

rvagg commented Oct 31, 2019

Yes, and I can't work out why $HOME is missing now that we've switched from FreeBSD to Linux for this. There's no special environment variables on the host machine.

@rvagg
Copy link
Member

rvagg commented Oct 31, 2019

I've restored the old FreeBSD servers while we figure this one out. These pipeline builds are the worst for debugging, I've got no idea where HOME has gone to, it's not showing up on an env from the script but there's nothing particularly special about the FreeBSD env compared to the Ubuntu one for that.

@rvagg
Copy link
Member

rvagg commented Oct 31, 2019

Got this sorted out, it was a configuration weirdness specific to the machine that has the most likelihood of being chosen for this task nodejs/build#2021, it's now back off FreeBSD.

gireeshpunathil pushed a commit that referenced this pull request Nov 3, 2019
@dev-script @gireeshpunathil
doc: explain http2 aborted event callback
8b53d0b 
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Refs: nodejs/help#877
PR-URL: #30179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil
Copy link
Member

landed as 8b53d0b

targos pushed a commit that referenced this pull request Nov 5, 2019
@dev-script @targos
doc: explain http2 aborted event callback
b7070f3 
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Refs: nodejs/help#877
PR-URL: #30179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@dev-script @targos
doc: explain http2 aborted event callback
8bd1743 
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Refs: nodejs/help#877
PR-URL: #30179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@dev-script @targos
doc: explain http2 aborted event callback
64c51ed 
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Refs: nodejs/help#877
PR-URL: #30179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@dev-script @targos
doc: explain http2 aborted event callback
d5aafde 
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Refs: nodejs/help#877
PR-URL: #30179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@dev-script @targos
doc: explain http2 aborted event callback
9c4a9e7 
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Refs: nodejs/help#877
PR-URL: #30179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document event arguments (http2, maybe more)
6 participants
@dev-script @gireeshpunathil @trivikr @nodejs-github-bot @richardlau @rvagg