Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: linkify .setupMaster() in cluster doc #30204

Closed
wants to merge 1 commit into from
Closed

doc: linkify .setupMaster() in cluster doc #30204

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 1, 2019

Refs: #30163

Checklist

@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Nov 1, 2019
@trivikr
Copy link
Member Author

trivikr commented Nov 2, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4027/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 2, 2019
gireeshpunathil pushed a commit that referenced this pull request Nov 3, 2019
@trivikr @gireeshpunathil
doc: linkify .setupMaster() in cluster doc
772ce0b 
Refs: #30163
PR-URL: #30204
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil
Copy link
Member

landed as 772ce0b

targos pushed a commit that referenced this pull request Nov 5, 2019
@trivikr @targos
doc: linkify .setupMaster() in cluster doc
201a60e 
Refs: #30163
PR-URL: #30204
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@trivikr @targos
doc: linkify .setupMaster() in cluster doc
fd05442 
Refs: #30163
PR-URL: #30204
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@trivikr @targos
doc: linkify .setupMaster() in cluster doc
d64a91c 
Refs: #30163
PR-URL: #30204
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@trivikr @targos
doc: linkify .setupMaster() in cluster doc
e5b2a8a 
Refs: #30163
PR-URL: #30204
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@trivikr @targos
doc: linkify .setupMaster() in cluster doc
b159b91 
Refs: #30163
PR-URL: #30204
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@trivikr trivikr deleted the linkify-setupMaster branch August 31, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@devnexen devnexen devnexen approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@trivikr @gireeshpunathil @addaleax @lpinca @devnexen @nodejs-github-bot