Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test: test configure ninja" #30295

Closed
wants to merge 1 commit into from
Closed

Revert "test: test configure ninja" #30295

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Nov 6, 2019

This reverts commit 85dd9e8.

make test should never change the current set of configure
flags.

Refs: #30033

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
Revert "test: test configure ninja"
87aac3f 
This reverts commit 85dd9e8.

`make test` should never change the current set of `configure`
flags.

Refs: nodejs#30033
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 6, 2019
@addaleax
Copy link
Member Author

addaleax commented Nov 6, 2019

Please 👍 this comment to approve fast-tracking, even without a full CI run.

This currently breaks ./configure with flags other than --ninja and makes the full Node.js build run twice (once without ninja, once with) when e.g. compiling addon tests.

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 6, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26401/

@addaleax
Copy link
Member Author

addaleax commented Nov 6, 2019

Landed in 3698031, thanks for the quick reviews!

@addaleax addaleax closed this Nov 6, 2019
addaleax added a commit that referenced this pull request Nov 6, 2019
@addaleax
Revert "test: test configure ninja"
3698031 
This reverts commit 85dd9e8.

`make test` should never change the current set of `configure`
flags.

Refs: #30033

PR-URL: #30295
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@addaleax addaleax deleted the revert-30033 branch November 6, 2019 11:46
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@addaleax @MylesBorins
Revert "test: test configure ninja"
8fe6849 
This reverts commit 85dd9e8.

`make test` should never change the current set of `configure`
flags.

Refs: #30033

PR-URL: #30295
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @gengjiawen @richardlau @targos