Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test cover prepare_stack_trace in case of trace is empty #30311

Closed
wants to merge 3 commits into from
Closed

test: test cover prepare_stack_trace in case of trace is empty #30311

wants to merge 3 commits into from

Conversation

telenord
Copy link

@telenord telenord commented Nov 6, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2019
@ChALkeR ChALkeR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2019
@telenord telenord changed the title test: test cover prepare_stack_trace in case when trace is empty test: test cover prepare_stack_trace in case of trace is empty Nov 6, 2019
@gireeshpunathil
Copy link
Member

cc @ChALkeR

@gireeshpunathil gireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 21, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26814/

@trivikr
Copy link
Member

trivikr commented Nov 21, 2019

@telenord The email used for the commit is not registered with GitHub.
Either change author info or register the email ID used in the commit with GitHub.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26896/

gireeshpunathil pushed a commit that referenced this pull request Nov 24, 2019
@gireeshpunathil
test: test cover cases when trace is empty
d90219d 
cover prepare_stack_trace in case when trace is empty
PR-URL: #30311
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil
Copy link
Member

landed in d90219d, thanks for the contribution!

addaleax pushed a commit that referenced this pull request Nov 30, 2019
@addaleax
test: test cover cases when trace is empty
01e0571 
cover prepare_stack_trace in case when trace is empty
PR-URL: #30311
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@targos
test: test cover cases when trace is empty
99770a0 
cover prepare_stack_trace in case when trace is empty
PR-URL: #30311
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@MylesBorins
test: test cover cases when trace is empty
0a068db 
cover prepare_stack_trace in case when trace is empty
PR-URL: #30311
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChALkeR ChALkeR ChALkeR left review comments

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@telenord @gireeshpunathil @nodejs-github-bot @trivikr @ChALkeR