Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules: reduce circular dependency of internal/modules/cjs/loader #30349

Closed
wants to merge 1 commit into from
Closed

modules: reduce circular dependency of internal/modules/cjs/loader #30349

wants to merge 1 commit into from

Commits on Nov 13, 2019

  1. modules: reduce circular dependency of internal/modules/cjs/loader 

    Previously `internal/bootstrap/pre_execution.js` requires
`internal/modules/cjs/loader.js` which in turn requires
`internal/bootstrap/pre_execution.js`. This patch moves the
entry point execution logic out of `pre_execution.js` and
puts it into `internal/modules/run_main.js`. It also tests
that `Module.runMain` can be monkey-patched before further
deprecation/refactoring can be done.

Also added an internal assertion `hasLoadedAnyUserCJSModule`
for documentation purposes.
    @joyeecheung
    joyeecheung committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    70b7123 View commit details
    Browse the repository at this point in the history