Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/internal: Use let instead of var for util.js and process/warning.js #30375

Closed
wants to merge 1 commit into from
Closed

lib/internal: Use let instead of var for util.js and process/warning.js #30375

wants to merge 1 commit into from

Conversation

19shubham11
Copy link
Contributor

@19shubham11 19shubham11 commented Nov 12, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added process Issues and PRs related to the process subsystem. util Issues and PRs related to the built-in util module. labels Nov 12, 2019
@19shubham11 19shubham11 changed the title lib/internal: this commit uses let instead of var for util.js and process/warning.js lib/internal: Use let instead of var for util.js and process/warning.js Nov 12, 2019
@19shubham11 19shubham11 force-pushed the use_let_instead_of_var branch from 3471857 to 0409a75 Compare November 12, 2019 15:14
@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@BridgeAR
Copy link
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4071/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26584/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26602/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26662/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27029/

@gireeshpunathil
Copy link
Member

the windows failure parallel/test-inspector-wait-for-connection is known as in #30619

the windows failure sequential/test-inspector-contexts is known as in #30519

the linux-containerized failure parallel/test-domain-error-types is known as in #30498

the failure in linux-containerized run node-api/test_make_callback/test-async-hooks-gcable is known as in #30648

gireeshpunathil pushed a commit that referenced this pull request Nov 26, 2019
@19shubham11 @gireeshpunathil
lib: use let instead of var
a2dfa3c 
this commit uses let instead of var for util.js & warning.js
PR-URL: #30375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil
Copy link
Member

landed in a2dfa3c

@19shubham11 19shubham11 deleted the use_let_instead_of_var branch November 26, 2019 14:33
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@19shubham11 @addaleax
lib: use let instead of var
b545b91 
this commit uses let instead of var for util.js & warning.js
PR-URL: #30375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@19shubham11 @targos
lib: use let instead of var
363391e 
this commit uses let instead of var for util.js & warning.js
PR-URL: #30375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@19shubham11 @MylesBorins
lib: use let instead of var
d138e2d 
this commit uses let instead of var for util.js & warning.js
PR-URL: #30375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. process Issues and PRs related to the process subsystem. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@19shubham11 @BridgeAR @nodejs-github-bot @gireeshpunathil @jasnell @cjihrig @BethGriggs @trivikr