Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: adds NO_COLOR to assert doc page #30483

Closed
wants to merge 4 commits into from
Closed

doc: adds NO_COLOR to assert doc page #30483

wants to merge 4 commits into from

Conversation

shobhitchittora
Copy link
Contributor

@shobhitchittora shobhitchittora commented Nov 14, 2019 •
edited
Loading

Adding NO_COLOR environment variable to disable colors to the assert docs.

Refs: #30484

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Nov 14, 2019
BridgeAR
BridgeAR reviewed Nov 14, 2019
View reviewed changes
doc/api/assert.md Outdated Show resolved Hide resolved
@shobhitchittora
Copy link
Contributor Author

@BridgeAR up for review!

vsemozhetbyt
vsemozhetbyt reviewed Nov 16, 2019
View reviewed changes
doc/api/assert.md Outdated Show resolved Hide resolved
@shobhitchittora @vsemozhetbyt
doc: adds parenthesis too function call
2aed44f 
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@lundibundi
Copy link
Member

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4076/

@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 18, 2019
addaleax pushed a commit that referenced this pull request Nov 18, 2019
@shobhitchittora @addaleax
doc: adds NO_COLOR to assert doc page
5bb4d85 
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@addaleax
Copy link
Member

Landed in 5bb4d85 🎉

@addaleax addaleax closed this Nov 18, 2019
BridgeAR pushed a commit that referenced this pull request Nov 19, 2019
@shobhitchittora @BridgeAR
doc: adds NO_COLOR to assert doc page
7f664e4 
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@shobhitchittora @targos
doc: adds NO_COLOR to assert doc page
8bb232f 
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@lpinca lpinca mentioned this pull request Dec 7, 2019
Closed
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@shobhitchittora @MylesBorins
doc: adds NO_COLOR to assert doc page
ec5fe99 
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@lundibundi lundibundi lundibundi approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shobhitchittora @lundibundi @addaleax @lpinca @BridgeAR @vsemozhetbyt @nodejs-github-bot