Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix -Winconsistent-missing-override warning #30549

Merged
merged 1 commit into from
Nov 20, 2019
Merged

src: fix -Winconsistent-missing-override warning #30549

merged 1 commit into from
Nov 20, 2019

Commits on Nov 20, 2019

  1. src: fix -Winconsistent-missing-override warning 

    This commit addresses the following warning:

../src/node_api.cc:28:19: warning: 'mark_arraybuffer_as_untransferable'
overrides a member function but is not marked 'override'
      [-Winconsistent-missing-override]
  v8::Maybe<bool> mark_arraybuffer_as_untransferable(
                  ^
../src/js_native_api_v8.h:42:27: note: overridden virtual function is here
  virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable(

PR-URL: nodejs#30549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
    @cjihrig
    cjihrig committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    3871cc5 View commit details
    Browse the repository at this point in the history