Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,doc: add C++ internals documentation #30552

Closed
wants to merge 13 commits into from
Closed

src,doc: add C++ internals documentation #30552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d3d23cd
src,doc: add C++ internals documentation
addaleax Nov 19, 2019
cbc4152
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
09386ef
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
4ef7a31
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
130ef12
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
2445c17
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
e1ca24c
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
309fab4
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
f50f971
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
9848ba5
fixup! fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
5a5f9e3
fixup! fixup! fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
7d32e28
fixup! src,doc: add C++ internals documentation
addaleax Nov 22, 2019
b49430d
fixup! src,doc: add C++ internals documentation
addaleax Nov 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CPP_STYLE_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# C++ Style Guide

See also the [C++ codebase README](src/README.md) for C++ idioms in the Node.js
codebase not related to stylistic issues.

## Table of Contents

* [Guides and References](#guides-and-references)
Expand Down
4 changes: 3 additions & 1 deletion doc/guides/contributing/pull-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ in the API docs will also be checked when running `make lint` (or
use `REPLACEME` for the version number in the documentation YAML.

For contributing C++ code, you may want to look at the
[C++ Style Guide](../../../CPP_STYLE_GUIDE.md).
[C++ Style Guide](../../../CPP_STYLE_GUIDE.md), as well as the
[README of `src/`](../../../src/README.md) for an overview over Node.js
C++ internals.

### Step 4: Commit

Expand Down
Loading