Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: set socket.server unconditionally #30571

Closed
wants to merge 1 commit into from
Closed

http: set socket.server unconditionally #30571

wants to merge 1 commit into from

Commits on Nov 20, 2019

  1. http: set socket.server unconditionally 

    This is useful for situations in which the socket was not
created for HTTP, e.g. when using arbitrary `Duplex` streams.

(The added test fails because previously, `socket.server.emit()`
would not work for emitting the `clientError` event, as
`socket.server` was `undefined`.)
    @addaleax
    addaleax committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    898a079 View commit details
    Browse the repository at this point in the history