test: test for minimum ICU version consistency #30608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
srl295
approved these changes
Nov 23, 2019
addaleax
approved these changes
Nov 23, 2019
richardlau
added
the
author ready
gengjiawen
approved these changes
Nov 23, 2019
cjihrig
approved these changes
Nov 23, 2019
The minimum ICU version for Node.js must be at least the minimum ICU version for V8. PR-URL: nodejs#30608 Refs: nodejs#30607 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
richardlau
force-pushed
the
mininum-icu
branch
from
3dab3f0
to
f2060fa
Compare
|
Landed in f2060fa. |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
The minimum ICU version for Node.js must be at least the minimum ICU version for V8. PR-URL: #30608 Refs: #30607 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
The minimum ICU version for Node.js must be at least the minimum ICU version for V8. PR-URL: #30608 Refs: #30607 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
The minimum ICU version for Node.js must be at least the minimum ICU version for V8. PR-URL: #30608 Refs: #30607 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum ICU version for Node.js must be at least the minimum ICU
version for V8.
Refs: #30607
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes