Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(worker): allow inspector.close() inside Worker #30680

Closed
wants to merge 1 commit into from
Closed

fix(worker): allow inspector.close() inside Worker #30680

wants to merge 1 commit into from

Conversation

oyyd
Copy link
Contributor

@oyyd oyyd commented Nov 27, 2019

inspector.close() is an alias of process._debugEnd() which is missing inside Worker enviroments. This PR allows calling it inside Worker.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@oyyd
fix(worker): allow inspector.close() inside Worker
f7f73c6 
inspector.close() is an alias of process._debugEnd() which is
missing inside Worker enviroments. This PR allows calling it inside
Worker.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 27, 2019
@addaleax addaleax added worker Issues and PRs related to Worker support. inspector Issues and PRs related to the V8 inspector protocol labels Nov 27, 2019
@addaleax
Copy link
Member

Should inspector.open() be allowed inside Workers? It opens the inspector for the entire process, not the current thread, right?

@eugeneo
Copy link
Contributor

eugeneo commented Nov 27, 2019

Inspector.close stops global inspector server. It should not be available in the worker.

@oyyd
Copy link
Contributor Author

oyyd commented Nov 28, 2019

I guess I have misunderstood the code.. I'm going to close this.

@oyyd oyyd closed this Nov 28, 2019
@ds3p2 ds3p2 mentioned this pull request Dec 13, 2021
Closed
@theanarkh theanarkh mentioned this pull request Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oyyd @addaleax @eugeneo @nodejs-github-bot