Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: improve checked uv loop close output #30814

Closed
wants to merge 2 commits into from
Closed

src: improve checked uv loop close output #30814

wants to merge 2 commits into from

Commits on Dec 6, 2019

  1. src: improve checked uv loop close output 

    Addon developers may run into this when not closing libuv handles
inside Workers.

Previously, output may have included unhelpful statements such as
`uv loop at ... has 0 active handles`, which may sound like
everything’s supposed to be fine actually.

So, instead of printing the active handle count, print the total
handle count and mark active handles individually.

Also, fix the test for this to work properly and make sure that
parsing finishes properly.
    @addaleax
    addaleax committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    c3d8efb View commit details
    Browse the repository at this point in the history

  2. fixup! src: improve checked uv loop close output

    @addaleax
    addaleax committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    3bb6d13 View commit details
    Browse the repository at this point in the history