Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: refactor Writable buffering #30974

Closed
wants to merge 1 commit into from
Closed

stream: refactor Writable buffering #30974

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Dec 15, 2019 •
edited
Loading

Re-open of #29026.

Simplifies the buffering logic in `Writable´.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Dec 15, 2019
@ronag ronag force-pushed the stream-writable-buffered2 branch 3 times, most recently from 548ef33 to e10969e Compare December 15, 2019 11:29
@ronag ronag force-pushed the stream-writable-buffered2 branch from e10969e to cb189a3 Compare December 15, 2019 11:59
@ronag
Copy link
Member Author

ronag commented Dec 15, 2019

Unfortunately, this makes async perf significantly worse.

@ronag ronag closed this Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronag @nodejs-github-bot