Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: unflag conditional exports #31001

Closed
wants to merge 2 commits into from
Closed

module: unflag conditional exports #31001

wants to merge 2 commits into from

Conversation

guybedford
Copy link
Contributor

This PR unflags conditional exports, which is a prerequisite to unflagging experimental modules and backporting to --experimental-modules on 12.x.

Opening this now so that we have time to discuss it thoroughly before January.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 17, 2019
@guybedford guybedford added esm Issues and PRs related to the ECMAScript Modules implementation. modules-agenda Issues and PRs to discuss during the meetings of the Modules team. labels Dec 17, 2019
@mhdawson mhdawson mentioned this pull request Dec 17, 2019
Closed
@guybedford
Copy link
Contributor Author

//cc @nodejs/modules-active-members

@Trott Trott added the pending label Dec 21, 2019
@Trott
Copy link
Member

Trott commented Dec 21, 2019

Created a pending label to hep indicate that this shouldn't land until the Modules team has taken it up. At least, that's my understanding. Remove the label if I'm wrong.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27906/

@guybedford
Copy link
Contributor Author

@Trott thanks for adding a 'pending' label - will use that pattern for PRs in need of group consensus / sign off / final confirmation.

@mhdawson mhdawson mentioned this pull request Dec 30, 2019
Closed
@mhdawson mhdawson mentioned this pull request Jan 6, 2020
Closed
@guybedford guybedford force-pushed the unflag-conditional-exports branch 2 times, most recently from a9989d6 to 63a3044 Compare January 7, 2020 04:40
MylesBorins
MylesBorins approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28304/

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BridgeAR
Copy link
Member

This needs a rebase.

@mhdawson mhdawson mentioned this pull request Jan 13, 2020
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 15, 2020 •
edited by MylesBorins
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/28446/
Rebuild windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/33227/

@MylesBorins
Copy link
Contributor

Landed in fc4e413

MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@guybedford @MylesBorins
module: unflag conditional exports
fc4e413 
PR-URL: #31001
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins added semver-minor PRs that contain new features and should be released in the next minor version. and removed modules-agenda Issues and PRs to discuss during the meetings of the Modules team. labels Jan 16, 2020
@richardlau
Copy link
Member

I don't think this PR has caused the regression but it has surfaced it (by unflagging --experimental-conditional-exports). Running CITGM on bluebird with 13.6.0 (which doesn't contain this PR) and NODE_OPTIONS=--experimental-conditional-exports produces the same failure: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/727/

Trott pushed a commit that referenced this pull request Jan 21, 2020
@guybedford @Trott
module: fix check exports issue in cjs module loading
c2c3274 
Refs: #31001 (comment)

PR-URL: #31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Jan 21, 2020
@Trott
test,module: add test for exports cjs loader check
dcba128 
Refs: nodejs#31001 (comment)

PR-URL: nodejs#31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Jan 21, 2020
@guybedford @codebytere
module: fix check exports issue in cjs module loading
cb27c2b 
Refs: #31001 (comment)

PR-URL: #31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Jan 21, 2020
@Trott @codebytere
test,module: add test for exports cjs loader check
cbd84c5 
Refs: #31001 (comment)

PR-URL: #31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere added a commit that referenced this pull request Jan 21, 2020
@codebytere
2020-01-21, Version 13.7.0 (Current)
bbab963 
Notable changes:

* deps:
  * upgrade to libuv 1.34.1 (cjihrig) #31332
  * upgrade npm to 6.13.6 (Ruy Adorno) #31304
* module
  * add API for interacting with source maps (bcoe) #31132
  * loader getSource, getFormat, transform hooks (Geoffrey Booth) #30986
  * logical conditional exports ordering (Guy Bedford) #31008
  * unflag conditional exports (Guy Bedford) #31001
* process:
  * allow monitoring uncaughtException (Gerhard Stoebich) #31257
* Added new collaborators:
  * [GeoffreyBooth](https://github.com/GeoffreyBooth) - Geoffrey Booth. #31306

PR-URL: #31382
codebytere added a commit that referenced this pull request Jan 21, 2020
@codebytere
2020-01-21, Version 13.7.0 (Current)
a484f1a 
Notable changes:

* deps:
  * upgrade to libuv 1.34.1 (cjihrig) #31332
  * upgrade npm to 6.13.6 (Ruy Adorno) #31304
* module
  * add API for interacting with source maps (bcoe) #31132
  * loader getSource, getFormat, transform hooks (Geoffrey Booth) #30986
  * logical conditional exports ordering (Guy Bedford) #31008
  * unflag conditional exports (Guy Bedford) #31001
* process:
  * allow monitoring uncaughtException (Gerhard Stoebich) #31257
* Added new collaborators:
  * [GeoffreyBooth](https://github.com/GeoffreyBooth) - Geoffrey Booth. #31306

PR-URL: #31382
MylesBorins pushed a commit that referenced this pull request Jan 28, 2020
@guybedford @MylesBorins
module: unflag conditional exports
5bd85cb 
PR-URL: #31001
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 28, 2020
@guybedford @MylesBorins
module: fix check exports issue in cjs module loading
c4795e6 
Refs: #31001 (comment)

PR-URL: #31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 28, 2020
@Trott @MylesBorins
test,module: add test for exports cjs loader check
fb74f9c 
Refs: #31001 (comment)

PR-URL: #31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jan 30, 2020
Closed
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Jan 30, 2020
@guybedford @MylesBorins
module: fix check exports issue in cjs module loading
9895cf1 
Refs: nodejs#31001 (comment)

PR-URL: nodejs#31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Jan 30, 2020
@Trott @MylesBorins
test,module: add test for exports cjs loader check
b888993 
Refs: nodejs#31001 (comment)

PR-URL: nodejs#31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 30, 2020
@guybedford @MylesBorins
module: unflag conditional exports
616a4ee 
PR-URL: #31001
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 30, 2020
@guybedford @MylesBorins
module: fix check exports issue in cjs module loading
db5ec52 
Refs: #31001 (comment)

PR-URL: #31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 30, 2020
@Trott @MylesBorins
test,module: add test for exports cjs loader check
ad4af04 
Refs: #31001 (comment)

PR-URL: #31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@guybedford @BethGriggs
module: unflag conditional exports
60490f4 
PR-URL: #31001
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@guybedford @BethGriggs
module: fix check exports issue in cjs module loading
624ed0e 
Refs: #31001 (comment)

PR-URL: #31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Trott @BethGriggs
test,module: add test for exports cjs loader check
ac9a893 
Refs: #31001 (comment)

PR-URL: #31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
@targos targos mentioned this pull request Feb 18, 2020
Closed
@jaydenseric jaydenseric mentioned this pull request Aug 4, 2020
Draft
@aduh95 aduh95 mentioned this pull request Nov 18, 2020
Closed
1 task
@il3ven il3ven mentioned this pull request Sep 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@guybedford @Trott @nodejs-github-bot @BridgeAR @MylesBorins @ljharb @richardlau @jasnell