module: unflag resolve self #31002
Closed
module: unflag resolve self #31002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
|
//cc @nodejs/modules-active-members |
MylesBorins
added
the
modules-agenda
MylesBorins
approved these changes
Dec 17, 2019
|
Should #31009 land before this does? |
|
That would probably be slightly preferable, although they could land in either order, so long as the bug fix lands before the unflagging is released. |
jasnell
approved these changes
Dec 18, 2019
MylesBorins
added
the
esm
|
I think we should land behavior changes before unflagging |
BridgeAR
added
author ready
guybedford
force-pushed
the
unflag-resolve-self
branch
from
e963247
to
c190b53
Compare
guybedford
added
blocked
|
The behaviour changes have landed in 8a96d05, so this is in theory ready to go now. |
guybedford
added
pending
and removed
blocked
ljharb
reviewed
Dec 29, 2019
guybedford
force-pushed
the
unflag-resolve-self
branch
from
c190b53
to
514a61d
Compare
Codecov Report
@@ Coverage Diff @@
## master #31002 +/- ##
=======================================
Coverage 97.33% 97.33%
=======================================
Files 189 189
Lines 63888 63888
=======================================
Hits 62184 62184
Misses 1704 1704Continue to review full report at Codecov.
|
Trott
approved these changes
Dec 30, 2019
jkrems
approved these changes
Dec 30, 2019
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
Jan 1, 2020
This comment has been minimized.
This comment has been minimized.
BridgeAR
pushed a commit
that referenced
this pull request
Jan 2, 2020
PR-URL: #31002 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in c7f328f 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
PR-URL: #31002 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
removed
the
modules-agenda
MylesBorins
pushed a commit
that referenced
this pull request
Jan 12, 2020
PR-URL: #31002 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #31002 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
dmail
pushed a commit
to jsenv/importmap-node-module
that referenced
this pull request
Jul 17, 2020
This major release is mostly about keeping import map for node module and writing importmap file separated. - replace generateImportMapForProjectPackage by getImportMapFromNodeModules - getImportMapFromNodeModules only return importmap, it does not write to filesystem anymore. - add getImportMapFromFile - add generateImportMapForProject - generate importmap for package self ref by default see nodejs/node#31002 - rename some parameter like favoredExports becoming packagesExportsPreference - ensure a package self reference is stronger than self dev dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unflags the
--experimental-resolve-selfoption, which allows packages to load their own"exports"definitions through an import to their own package name.For CommonJS this approach is backwards-compatible because the own name resolution is only attempted after all other resolutions fail.Backwards compatibility is now ensured by only supporting own-name resolution when
"exports"in the package.json is set. When it is, this resolution applies before any node_modules lookup checks.Opening now to discuss along with overall resolver stability concerns.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes