stream: reset flowing state if no 'readable' or 'data' listeners.

lib/_stream_readable.js

@@ -126,7 +126,7 @@ function ReadableState(options, stream, isDuplex) {
  this.emittedReadable = false;
  this.readableListening = false;
  this.resumeScheduled = false;
- this.paused = true;
+ this.paused = null;
 
  // True if the error was already emitted and should not be thrown again
  this.errorEmitted = false;
@@ -368,7 +368,7 @@ function chunkInvalid(state, chunk) {
 
 
 Readable.prototype.isPaused = function() {
- return this._readableState.flowing === false;
+ return this._readableState.paused === true;
 };
 
 // Backwards compatibility.
@@ -967,14 +967,16 @@ function updateReadableListening(self) {
  const state = self._readableState;
  state.readableListening = self.listenerCount('readable') > 0;
 
- if (state.resumeScheduled && !state.paused) {
+ if (state.resumeScheduled && state.paused === false) {
  // Flowing needs to be set to true now, otherwise
  // the upcoming resume will not flow.
  state.flowing = true;
 
  // Crude way to check if we should resume
  } else if (self.listenerCount('data') > 0) {
  self.resume();
+ } else if (!state.readableListening) {
+ state.flowing = null;
  }
 }
 

test/parallel/test-stream-readable-data.js

@@ -0,0 +1,19 @@
+'use strict';
+const common = require('../common');
+
+const { Readable } = require('stream');
+
+const readable = new Readable({
+ read() {}
+});
+
+function read() {}
+
+readable.setEncoding('utf8');
+readable.on('readable', read);
+readable.removeListener('readable', read);
+
+process.nextTick(function() {
+ readable.on('data', common.mustCall());
+ readable.push('hello');
+});

test/parallel/test-stream-readable-pause-and-resume.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const common = require('../common');
+const assert = require('assert');
 const { Readable } = require('stream');
 
 let ticks = 18;
@@ -38,3 +39,20 @@ function readAndPause() {
 
  rs.on('data', ondata);
 }
+
+{
+ const readable = new Readable({
+ read() {}
+ });
+
+ function read() {}
+
+ readable.setEncoding('utf8');
+ readable.on('readable', read);
+ readable.removeListener('readable', read);
+ readable.pause();
+
+ process.nextTick(function() {
+ assert(readable.isPaused()); // Throws.
+ });
+}