Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: include writev & callback in benchmark #31066

Closed
wants to merge 5 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Dec 23, 2019

Currently we only consider write when benchmarking.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Currently we only consider write when benchmarking.
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. stream Issues and PRs related to the stream subsystem. labels Dec 23, 2019
@ronag ronag changed the title benchmark: include writev in benchmark benchmark: include writev & callback in benchmark Dec 23, 2019
benchmark/streams/writable-manywrites.js Outdated Show resolved Hide resolved
benchmark/streams/writable-manywrites.js Outdated Show resolved Hide resolved
@ronag ronag mentioned this pull request Dec 23, 2019
4 tasks
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually requires the following test to be changed:

test/benchmark/test-benchmark-streams.js

@ronag
Copy link
Member Author

ronag commented Dec 24, 2019

This actually requires the following test to be changed:

test/benchmark/test-benchmark-streams.js

Sorry, this is new for me. What is that and how does it need to be changed?

@BridgeAR
Copy link
Member

If you run the test with this addition, it will fail due to the added options that are not included in the test. It is a way to verify that at least one benchmark option passes for all benchmark files of the specific subsystem.

You could add something like writev: 'yes', callback: 'no'.

@ronag ronag requested a review from BridgeAR December 25, 2019 10:27
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 25, 2019
@BridgeAR
Copy link
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4115/

Marking as author ready. The benchmark test should be run while landing to verify that it works properly.

@BridgeAR
Copy link
Member

BridgeAR commented Dec 25, 2019

Landed in f68285b 🎉

@BridgeAR BridgeAR closed this Dec 25, 2019
BridgeAR pushed a commit that referenced this pull request Dec 25, 2019
Currently we only consider write when benchmarking.

PR-URL: #31066
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
Currently we only consider write when benchmarking.

PR-URL: #31066
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos pushed a commit that referenced this pull request Jan 14, 2020
Currently we only consider write when benchmarking.

PR-URL: #31066
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
Currently we only consider write when benchmarking.

PR-URL: #31066
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants