-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: include writev & callback in benchmark #31066
Conversation
Currently we only consider write when benchmarking.
1f863ee
to
4155712
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually requires the following test to be changed:
test/benchmark/test-benchmark-streams.js
Sorry, this is new for me. What is that and how does it need to be changed? |
If you run the test with this addition, it will fail due to the added options that are not included in the test. It is a way to verify that at least one benchmark option passes for all benchmark files of the specific subsystem. You could add something like |
Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4115/ Marking as author ready. The benchmark test should be run while landing to verify that it works properly. |
Landed in f68285b 🎉 |
Currently we only consider write when benchmarking. PR-URL: #31066 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Currently we only consider write when benchmarking. PR-URL: #31066 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Currently we only consider write when benchmarking. PR-URL: #31066 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Currently we only consider write when benchmarking. PR-URL: #31066 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Currently we only consider write when benchmarking.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes