test: increase coverage for _http_incoming.js #31093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
approved these changes
Dec 25, 2019
Trott
added
the
author ready
cjihrig
approved these changes
Dec 26, 2019
ZYSzys
approved these changes
Dec 26, 2019
devnexen
approved these changes
Dec 26, 2019
jasnell
approved these changes
Dec 26, 2019
trivikr
approved these changes
Dec 27, 2019
antsmartian
approved these changes
Dec 27, 2019
|
Landed in 1929135 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 28, 2019
Add coverage for IncomingMessage.prototype.connection setter. PR-URL: nodejs#31093 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Trott
force-pushed
the
connection-setter
branch
from
d6d40a2
to
1929135
Compare
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
Add coverage for IncomingMessage.prototype.connection setter. PR-URL: #31093 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add coverage for IncomingMessage.prototype.connection setter.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes