build: switch realpath to pwd #31095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
Member
@nodejs/build |
Member
@nodejs/python @nodejs/build-files |
addaleax
approved these changes
Dec 26, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Do we need the prefix at all? Other parts of node.gypi also refer to source tree files using relative paths, so I’d expect that to work too
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@addaleax having experimented with our CI, it does seem that the path provided to the linker needs to be absolute; I've reverted to the prior |
gabrielschulhof
approved these changes
Dec 26, 2019
This comment has been minimized.
This comment has been minimized.
Collaborator
Collaborator
BridgeAR
approved these changes
Dec 27, 2019
Member
|
Maybe fast track this to fix the coverage builds? |
gabrielschulhof
added
the
fast-track
gabrielschulhof
pushed a commit
that referenced
this pull request
Dec 27, 2019
PR-URL: #31095 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Contributor
|
Landed in ce0fb0f. |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Dec 31, 2019
PR-URL: nodejs#31095 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
PR-URL: #31095 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Merged
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Mar 6, 2020
PR-URL: nodejs#31095 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 9, 2020
PR-URL: nodejs#31095 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Backport-PR-URL: nodejs#32092 PR-URL: nodejs#31095 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our test coverage linux machine doesn't have the
realpathbin, which I believe comes in as part ofcoreutils?This became an issue in #30954, which I believe caused
realpathto start getting invoked on these machines for the first time.I believe we can simply swap out the use of
realpathtopwd, for our purposes.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes