doc: add an example for util.types.isExternal #31173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
jasnell
reviewed
Jan 3, 2020
BridgeAR
reviewed
Jan 3, 2020
addaleax
reviewed
Jan 4, 2020
HarshithaKP
added a commit
to HarshithaKP/node
that referenced
this pull request
Jan 6, 2020
There is a reference to native external types in util.types.isExternal api documentation. Provide a brief explanation to that. Refs: nodejs#31173 (comment)
4 tasks
addaleax
reviewed
Jan 6, 2020
BridgeAR
approved these changes
Jan 6, 2020
BridgeAR
added
the
author ready
Trott
reviewed
Jan 6, 2020
gireeshpunathil
pushed a commit
that referenced
this pull request
Jan 8, 2020
There is a reference to native external types in util.types.isExternal api documentation. Provide a brief explanation to that. Refs: #31173 (comment) PR-URL: #31214 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
antsmartian
approved these changes
Jan 8, 2020
added usage example for util.types.isExternal which was missing owing to the complexity. Used a combination of n-api and js to demonstrate usage of the api. Fixes: nodejs#20604
HarshithaKP
force-pushed
the
utils.types.isExternal_example
branch
from
3051444 to
aa6096d
Compare
addaleax
approved these changes
Jan 10, 2020
Trott
approved these changes
Jan 10, 2020
Trott
removed
the
author ready
Trott
added
the
author ready
BridgeAR
pushed a commit
that referenced
this pull request
Jan 13, 2020
added usage example for util.types.isExternal which was missing owing to the complexity. Used a combination of n-api and js to demonstrate usage of the api. PR-URL: #31173 Fixes: #20604 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in f4a4a1a 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
There is a reference to native external types in util.types.isExternal api documentation. Provide a brief explanation to that. Refs: #31173 (comment) PR-URL: #31214 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
added usage example for util.types.isExternal which was missing owing to the complexity. Used a combination of n-api and js to demonstrate usage of the api. PR-URL: #31173 Fixes: #20604 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
There is a reference to native external types in util.types.isExternal api documentation. Provide a brief explanation to that. Refs: #31173 (comment) PR-URL: #31214 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
added usage example for util.types.isExternal which was missing owing to the complexity. Used a combination of n-api and js to demonstrate usage of the api. PR-URL: #31173 Fixes: #20604 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
added usage example for util.types.isExternal which was missing owing to the complexity. Used a combination of n-api and js to demonstrate usage of the api. PR-URL: #31173 Fixes: #20604 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added usage example for util.types.isExternal
which was missing owing to the complexity.
Used a combination of n-api and js to demonstrate
usage of the api.
Fixes: #20604
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes