Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: replace BigInt64Array global by the primordials #31193

Conversation

Sebastien-Ahkrin
Copy link
Contributor

Hello,
For this PR I have added BigInt64Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: BigInt64Array
      message: "Use `const { BigInt64Array } = primordials;` instead of the global."

And just add Set.

const {
  // [...]
  BigInt64Array,
} = primordials;

I hope this new PR will help you :x

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Jan 5, 2020
@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

lib/.eslintrc.yaml Outdated Show resolved Hide resolved
@Sebastien-Ahkrin Sebastien-Ahkrin force-pushed the BigInt64ArrayPrimordials branch from 7ce528a to b8bd276 Compare January 5, 2020 13:08
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott
Copy link
Member

Trott commented Jan 8, 2020

Needs a rebase to fix the conflict. (Looks like you can just accept both the "theirs" and the "ours" changes and it will be fine.)

@Sebastien-Ahkrin Sebastien-Ahkrin force-pushed the BigInt64ArrayPrimordials branch from b8bd276 to fe53967 Compare January 9, 2020 16:29
@Sebastien-Ahkrin
Copy link
Contributor Author

Needs a rebase to fix the conflict. (Looks like you can just accept both the "theirs" and the "ours" changes and it will be fine.)

Fix in progress 😄

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 11, 2020
BridgeAR pushed a commit that referenced this pull request Jan 13, 2020
PR-URL: #31193
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR
Copy link
Member

Landed in a2c4244 🎉

@BridgeAR BridgeAR closed this Jan 13, 2020
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020

Unverified

The email in this signature doesn’t match the committer email.
PR-URL: #31193
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Jan 16, 2020
codebytere pushed a commit that referenced this pull request Mar 14, 2020

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
PR-URL: #31193
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020

Unverified

The email in this signature doesn’t match the committer email.
PR-URL: #31193
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants