-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: replace BigInt64Array global by the primordials #31193
Closed
Sebastien-Ahkrin
wants to merge
1
commit into
nodejs:master
from
Sebastien-Ahkrin:BigInt64ArrayPrimordials
Closed
lib: replace BigInt64Array global by the primordials #31193
Sebastien-Ahkrin
wants to merge
1
commit into
nodejs:master
from
Sebastien-Ahkrin:BigInt64ArrayPrimordials
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
util
Issues and PRs related to the built-in util module.
label
Jan 5, 2020
Refs: #30697 |
addaleax
approved these changes
Jan 5, 2020
targos
approved these changes
Jan 5, 2020
Sebastien-Ahkrin
force-pushed
the
BigInt64ArrayPrimordials
branch
from
January 5, 2020 13:08
7ce528a
to
b8bd276
Compare
trivikr
approved these changes
Jan 5, 2020
cjihrig
approved these changes
Jan 5, 2020
jasnell
approved these changes
Jan 6, 2020
BridgeAR
approved these changes
Jan 6, 2020
Trott
approved these changes
Jan 7, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Needs a rebase to fix the conflict. (Looks like you can just accept both the "theirs" and the "ours" changes and it will be fine.) |
Sebastien-Ahkrin
force-pushed
the
BigInt64ArrayPrimordials
branch
from
January 9, 2020 16:29
b8bd276
to
fe53967
Compare
Fix in progress 😄 |
BridgeAR
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jan 11, 2020
BridgeAR
pushed a commit
that referenced
this pull request
Jan 13, 2020
PR-URL: #31193 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Landed in a2c4244 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
PR-URL: #31193 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
PR-URL: #31193 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #31193 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
For this PR I have added BigInt64Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".
And just add Set.
I hope this new PR will help you :x