Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: replace BigUInt64Array global by the primordials #31194

Closed
wants to merge 1 commit into from
Closed

lib: replace BigUInt64Array global by the primordials #31194

wants to merge 1 commit into from

Conversation

Sebastien-Ahkrin
Copy link
Contributor

Hello,
For this PR I have added BigUInt64Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: BigUInt64Array
      message: "Use `const { BigUInt64Array } = primordials;` instead of the global."

And just add Set.

const {
  // [...]
  BigUInt64Array,
} = primordials;

I hope this new PR will help you :x

@nodejs-github-bot nodejs-github-bot added process Issues and PRs related to the process subsystem. util Issues and PRs related to the built-in util module. labels Jan 5, 2020
@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

targos
targos approved these changes Jan 5, 2020
View reviewed changes
lib/.eslintrc.yaml Outdated Show resolved Hide resolved
@Sebastien-Ahkrin Sebastien-Ahkrin force-pushed the BigUint64ArrayPrimordials branch from ed37e3e to 2b819da Compare January 5, 2020 13:05
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28249/

@Trott
Copy link
Member

Trott commented Jan 7, 2020

Landed in 4f51c12

Trott pushed a commit that referenced this pull request Jan 7, 2020
@Sebastien-Ahkrin @Trott
lib: replace BigUInt64Array global by the primordials
4f51c12 
PR-URL: #31194
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott closed this Jan 7, 2020
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@Sebastien-Ahkrin @MylesBorins
lib: replace BigUInt64Array global by the primordials
aafeab8 
PR-URL: #31194
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@Sebastien-Ahkrin @codebytere
lib: replace BigUInt64Array global by the primordials
68d48fe 
PR-URL: #31194
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Sebastien-Ahkrin @nodejs-github-bot @Trott @jasnell @targos @cjihrig @BridgeAR @trivikr