Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve doc v8.getHeapSpaceStatistics() #31274

Closed
wants to merge 1 commit into from
Closed

doc: improve doc v8.getHeapSpaceStatistics() #31274

wants to merge 1 commit into from

Conversation

dev-script
Copy link
Contributor

'GetHeapSpaceStatistics' Link replaced in v8 getHeapSpaceStatistics
function because it was showing 404 page not found.

Fixes: #31181

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@dev-script
doc: improve doc v8.getHeapSpaceStatistics()
f16952a 
'GetHeapSpaceStatistics' Link replaced in v8 getHeapSpaceStatistics
function because it was showing 404 page not found.

Fixes: #31181
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 9, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2020
Trott
Trott approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I'd guess it's only a matter of time before this 404s again. But until then!

Trott pushed a commit that referenced this pull request Jan 11, 2020
@dev-script @Trott
doc: improve doc v8.getHeapSpaceStatistics() 'GetHeapSpaceStatistics'
2a94c9f 
Link replaced in v8 getHeapSpaceStatistics function because it was
showing 404 page not found.

Fixes: #31181

PR-URL: #31274
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Jan 11, 2020

Landed in 2a94c9f

@Trott Trott closed this Jan 11, 2020
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@dev-script @MylesBorins
doc: improve doc v8.getHeapSpaceStatistics() 'GetHeapSpaceStatistics'
6184f1a 
Link replaced in v8 getHeapSpaceStatistics function because it was
showing 404 page not found.

Fixes: #31181

PR-URL: #31274
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@dev-script @codebytere
doc: improve doc v8.getHeapSpaceStatistics() 'GetHeapSpaceStatistics'
b01b75c 
Link replaced in v8 getHeapSpaceStatistics function because it was
showing 404 page not found.

Fixes: #31181

PR-URL: #31274
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@dev-script @codebytere
doc: improve doc v8.getHeapSpaceStatistics() 'GetHeapSpaceStatistics'
fa0762d 
Link replaced in v8 getHeapSpaceStatistics function because it was
showing 404 page not found.

Fixes: #31181

PR-URL: #31274
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v8.getHeapSpaceStatistics() link to GetHeapSpaceStatistics() is broken