n-api: return napi_invalid_arg on napi_create_bigint_words #31312
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
N-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs.
legendecas
force-pushed
the
napi_bigint_throwing
branch
from
326610c
to
ccc6cd5
Compare
addaleax
approved these changes
Jan 11, 2020
cjihrig
approved these changes
Jan 11, 2020
tniessen
approved these changes
Jan 11, 2020
BridgeAR
approved these changes
Jan 11, 2020
BridgeAR
added
the
author ready
Trott
approved these changes
Jan 13, 2020
mhdawson
approved these changes
Jan 13, 2020
Trott
pushed a commit
that referenced
this pull request
Jan 14, 2020
N-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs. PR-URL: #31312 Refs: #29849 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in 689ab46 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
N-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs. PR-URL: #31312 Refs: #29849 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
N-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs. PR-URL: #31312 Refs: #29849 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
N-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs. PR-URL: #31312 Refs: #29849 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N-API statuses shall be preferred over throwing JavaScript Errors on
checks occurred in N-APIs.
Refs: #29849
These changes shall not be made on existing N-API. But BigInt related N-API is still an experimental API.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes