Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: further fix async iterator example #31367

Closed
wants to merge 1 commit into from
Closed

docs: further fix async iterator example #31367

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jan 15, 2020

Further fixes an issue with the async iterator example where an
incorrect assumption was made in regards that drain or error
is always invoked after !write().

Fixes: #31365

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jan 15, 2020
@ronag ronag force-pushed the fix-docs-iterator-stream branch from 2b33725 to 3746d8f Compare January 15, 2020 09:31
@ronag
docs: further fix async iterator example
883d94c 
Further fixes an issue with the async iterator example where an
incorrect assumption was made in regards that drain or error
is always invoked after !write().

Fixes: nodejs#31365
@ronag ronag force-pushed the fix-docs-iterator-stream branch from 3746d8f to 883d94c Compare January 15, 2020 10:23
@Trott
Copy link
Member

Trott commented Jan 16, 2020

@nodejs/streams

mcollina
mcollina approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ronag added a commit that referenced this pull request Jan 24, 2020
@ronag
doc: further fix async iterator example
4fefd18 
Further fixes an issue with the async iterator example where an
incorrect assumption was made in regards that drain or error
is always invoked after !write().

Fixes: #31365

PR-URL: #31367
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ronag
Copy link
Member Author

ronag commented Jan 24, 2020

Landed in 4fefd18

@ronag ronag closed this Jan 24, 2020
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@ronag @codebytere
doc: further fix async iterator example
729b961 
Further fixes an issue with the async iterator example where an
incorrect assumption was made in regards that drain or error
is always invoked after !write().

Fixes: #31365

PR-URL: #31367
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@ronag @codebytere
doc: further fix async iterator example
62ded87 
Further fixes an issue with the async iterator example where an
incorrect assumption was made in regards that drain or error
is always invoked after !write().

Fixes: #31365

PR-URL: #31367
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@ronag @codebytere
doc: further fix async iterator example
821b9ac 
Further fixes an issue with the async iterator example where an
incorrect assumption was made in regards that drain or error
is always invoked after !write().

Fixes: #31365

PR-URL: #31367
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

@addaleax addaleax Awaiting requested review from addaleax

@lundibundi lundibundi Awaiting requested review from lundibundi

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: writable streams from async iterators example issue
5 participants
@ronag @Trott @mcollina @lpinca @nodejs-github-bot