Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove bluebird remnants from test fixture #31435

Merged
merged 1 commit into from
Jan 23, 2020
+19 −159
Merged

test: remove bluebird remnants from test fixture #31435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 0 additions & 78 deletions test/fixtures/bluebird/node_modules/bluebird/package.json
View file
Open in desktop

This file was deleted.

78 changes: 0 additions & 78 deletions test/fixtures/bluebird/package.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion test/fixtures/bluebird/test.js
View file
Open in desktop

This file was deleted.

0 ...e_modules/bluebird/js/release/bluebird.js → ..._modules/package-main-enoent/fhqwhgads.js
View file
Open in desktop
File renamed without changes.
4 changes: 4 additions & 0 deletions test/fixtures/package-main-enoent/node_modules/package-main-enoent/package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions test/fixtures/package-main-enoent/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "package-main-enoent",
"main": "./fhqwhgads.js"
}
8 changes: 8 additions & 0 deletions test/fixtures/package-main-enoent/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
'use strict';

// The path in "main" in "package.json" does not exist here, but it does in
// the copy in node_modules. This is being tested because bluebird tests depend
// on this behavior and it was accidentally broken by a seemingly unrelated
// commit on master.

require('package-main-enoent');
5 changes: 3 additions & 2 deletions test/parallel/test-require-invalid-main-no-exports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ const assert = require('assert');
const { spawnSync } = require('child_process');
const fixtures = require('../common/fixtures');

const { error, status, stderr } =
spawnSync(process.execPath, [fixtures.path('bluebird', 'test.js')]);
const testFile = fixtures.path('package-main-enoent', 'test.js');

const { error, status, stderr } = spawnSync(process.execPath, [testFile]);

assert.ifError(error);
assert.strictEqual(status, 0, stderr);