Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove redundant properties from headers #31492

Closed
wants to merge 1 commit into from
Closed

doc: remove redundant properties from headers #31492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions doc/api_assets/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,29 @@ h4, h4 code { font-size: 1.5rem; }
h5, h5 code { font-size: 1.25rem; }
h6, h6 code { font-size: 1rem; }

h1, h1 code,
h2, h2 code,
h3, h3 code,
h4, h4 code,
h5, h5 code,
h6, h6 code {
color: inherit;
font-family: inherit;
h1,
h2,
h3,
h4,
h5,
h6 {
font-weight: 700;
line-height: inherit;
position: relative;
margin: 1.5rem 0 1rem;
text-rendering: optimizeLegibility;
}

h1 code,
h2 code,
h3 code,
h4 code,
h5 code,
h6 code {
color: inherit;
font-family: inherit;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

font-family can be removed later too @Trott so that the code is using the same font as everywhere else. AFAICT only the color is needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

font-family can be removed later too @Trott so that the code is using the same font as everywhere else. AFAICT only the color is needed

I thought about doing that in a second commit here, but I want to make sure there aren't any weird kerning issues or anything when we do that. So I was going to save that for another PR. I'm really good at rationalizing dividing CSS changes across multiple PRs apparently. But if you're more confident it won't be a problem, feel free to add it to this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually meant to make it in a separate PR later. Now that the selectors are split, it should be easier to maintain.

}

pre,
tt,
code,
Expand Down