Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintaining-V8.md #31503

Closed
wants to merge 2 commits into from
Closed

Update maintaining-V8.md #31503

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcd20b2
Update maintaining-V8.md
kzs0 Jan 25, 2020
e51bc5e
Update maintaining-V8.md
kzs0 Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions doc/guides/maintaining-V8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ For example, at the time of this writing:

All older branches are abandoned and are not maintained by the V8 team.

### V8 merge process overview
### V8 Merge Process Overview

The process for backporting bug fixes to active branches is officially
documented [on the V8 wiki][V8MergingPatching]. The summary of the process is:
Expand Down Expand Up @@ -278,7 +278,7 @@ PR-URL: https://github.com/nodejs/node/pull/7833
normal and [V8 CI][] using the Node.js CI system. We only needed to backport
to `v6.x` as the other LTS branches weren't affected by this bug.

### Backports Identified by the V8 team
### Backports Identified by the V8 Team

For bugs found through the browser or other channels, the V8 team marks bugs
that might be applicable to the abandoned branches in use by Node.js. This is
Expand Down Expand Up @@ -317,7 +317,7 @@ V8 builds against the version of ICU supplied by Node.js,
see [maintaining-icu.md](./maintaining-icu.md) for special considerations.
Specifically, a V8 update may necessitate an ICU update.

### Minor updates (patch level)
### Minor Updates (Patch Level)

Because there may be floating patches on the version of V8 in Node.js, it is
safest to apply the patch level updates as a patch. For example, imagine that
Expand Down Expand Up @@ -382,7 +382,7 @@ git node v8 major --branch=5.1-lkgr

This should be followed up with manual refloating of all relevant patches.

## Proposal: Using a fork repo to track upstream V8
## Proposal: Using a Fork Repo to Track Upstream V8

The fact that Node.js keeps a vendored, potentially edited copy of V8 in deps/
makes the above processes a bit complicated. An alternative proposal would be to
Expand Down