Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: Fix crash when internal debug enabled #31511

Closed
wants to merge 1 commit into from
Closed

tls: Fix crash when internal debug enabled #31511

wants to merge 1 commit into from

Conversation

rustyconover
Copy link
Contributor

When NODE_DEBUG_NATIVE is enabled for tls a debug statement
is sometimes called with error_str set to null, this causes
a crash from glibc since string format parameters should not
be null.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@rustyconover
tls: Fix crash when internal debug enabled
cbe7f2b 
When NODE_DEBUG_NATIVE is enabled for tls a debug statement
is sometimes called with error_str set to null, this causes
a crash from glibc since string format parameters should not
be null.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem. labels Jan 25, 2020
@rustyconover rustyconover requested a review from addaleax January 25, 2020 18:03
@addaleax
Copy link
Member

Sorry – this might be something I didn’t catch during #31446 – Maybe we could update the const char* variant in ToStringHelper (debug_utils-inl.h) to gracefully handle nullptr by returning a replacment string in that case, e.g. (null)? That would match the glibc behaviour…

@rustyconover
Copy link
Contributor Author

See PR #31523.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustyconover @addaleax @nodejs-github-bot