Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix ignore GCC -Wcast-function-type for older compilers #31524

Closed
wants to merge 1 commit into from
Closed

src: fix ignore GCC -Wcast-function-type for older compilers #31524

wants to merge 1 commit into from

Conversation

lundibundi
Copy link
Member

Fixes: #31517

I don't have an easy access to pre-8 GCC compiler so I haven't explicitly tested this. Perhaps @mscdex can check if this fixes your issue?

GCC8 changelog https://gcc.gnu.org/gcc-8/changes.html which denotes the addition of Wcast-function-type.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 26, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28688/

@mscdex
Copy link
Contributor

mscdex commented Jan 26, 2020 •
edited
Loading

As mentioned in the issue, the new warning was visible in CI even. Checking the output for this PR on the Ubuntu 18.04 CI node, I no longer see the new warning.

@richardlau
Copy link
Member

I don't have an easy access to pre-8 GCC compiler so I haven't explicitly tested this.

In addition to our CI (which uses pre-8 GCC compilers), our Travis CI builds use GCC 6 and GitHub Actions Linux runners use GCC 7. The new warnings no longer appear in the logs for those builds for this PR while they do for the equivalent logs for #31475.

danbev
danbev approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@danbev danbev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Trott
Copy link
Member

Trott commented Jan 29, 2020

Landed in 2462a2c

@Trott Trott closed this Jan 29, 2020
Trott pushed a commit that referenced this pull request Jan 29, 2020
@lundibundi @Trott
src: fix ignore GCC -Wcast-function-type for older compilers
2462a2c 
Fixes: #31517

PR-URL: #31524
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Feb 5, 2020
Closed
Closed
addaleax pushed a commit that referenced this pull request Feb 5, 2020
@lundibundi @addaleax
src: fix ignore GCC -Wcast-function-type for older compilers
f4bd6e1 
Fixes: #31517

PR-URL: #31524
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@lundibundi @BethGriggs
src: fix ignore GCC -Wcast-function-type for older compilers
71699e9 
Fixes: #31517

PR-URL: #31524
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@lundibundi @codebytere
src: fix ignore GCC -Wcast-function-type for older compilers
83dd65a 
Fixes: #31517

PR-URL: #31524
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@lundibundi @codebytere
src: fix ignore GCC -Wcast-function-type for older compilers
ceaab49 
Fixes: #31517

PR-URL: #31524
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@lundibundi @codebytere
src: fix ignore GCC -Wcast-function-type for older compilers
de6d552 
Fixes: #31517

PR-URL: #31524
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler warnings with recent commit
7 participants
@lundibundi @nodejs-github-bot @mscdex @richardlau @Trott @danbev @cjihrig