stream: fix finished writable/readable state #31527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
writable/readable does not indicate whether as stream is a Writable/Readable. This implements a better check for whether a object is a Writable/Readable.
|
Might be semver-major? |
|
why should it be semver-major? |
|
It can give |
mcollina
added
the
baking-for-lts
|
What happen in the given case in master? |
mcollina
reviewed
Jan 26, 2020
It won't call the callback at all... good call. Bug fix? |
|
I’ll go with a patch, with a long backing for lts backport |
lpinca
reviewed
Jan 27, 2020
lpinca
approved these changes
Jan 27, 2020
ronag
added
the
author ready
|
@mcollina: approves? |
JungMinu
approved these changes
Jan 27, 2020
Trott
approved these changes
Jan 28, 2020
|
Landed in b851d7b |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jan 29, 2020
writable/readable does not indicate whether as stream is a Writable/Readable. This implements a better check for whether a object is a Writable/Readable. PR-URL: nodejs#31527 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
writable/readable does not indicate whether as stream is a Writable/Readable. This implements a better check for whether a object is a Writable/Readable. PR-URL: #31527 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
added
backport-blocked-v12.x
and removed
author ready
3 tasks
targos
removed
the
baking-for-lts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writable/readable does not indicate whether as stream is
a Writable/Readable. This implements a better check for
whether a object is a Writable/Readable.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes