Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test,benchmark fix test-benchmark-zlib #31538

Closed
wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 27, 2020

Collaborators, please 👍 here to fast-track. This fixes a test that fails in node-daily-master.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem. labels Jan 27, 2020
@Trott
Copy link
Member Author

Trott commented Jan 27, 2020

Benchmark CI test (queued): https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/11828/ 👍

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 27, 2020
Trott added a commit that referenced this pull request Jan 30, 2020
PR-URL: #31538
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jan 30, 2020

Landed in 5cf789e

@Trott Trott closed this Jan 30, 2020
@Trott Trott deleted the zlib-bench-test branch January 30, 2020 03:17
codebytere pushed a commit that referenced this pull request Feb 17, 2020
PR-URL: #31538
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
codebytere pushed a commit that referenced this pull request Mar 15, 2020
PR-URL: #31538
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
PR-URL: #31538
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
@targos
Copy link
Member

targos commented Apr 18, 2020

Depends on #31201 to land on v12.x

targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
PR-URL: nodejs#31538
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #31538
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants