Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove --experimental-worker env option #31577

Closed
wants to merge 1 commit into from

Conversation

HarshithaKP
Copy link
Member

worker is stable in the master, the flag is
no more required.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

worker is stable in the master, the flag is
no more required.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 30, 2020
@HarshithaKP
Copy link
Member Author

One failure in test/parallel/test-worker-fs-stat-watcher.js which will be fixed through PR #31563

@richardlau
Copy link
Member

workers are still experimental in 10.x and requires the flag there. #25361 made the flag a no-op rather than removing it. Not having the flag in master means that scripts that pass --experimental-worker to node would work on Node.js 10 but break on a version of Node.js where the flag has been removed.

I'd prefer to keep the flag as a no-op until 10.x becomes End-of-Life.

@richardlau
Copy link
Member

or @addaleax would we consider taking workers out of experimental for 10.x before it goes into maintenance in April?

@richardlau richardlau added the worker Issues and PRs related to Worker support. label Jan 30, 2020
@addaleax
Copy link
Member

I'd prefer to keep the flag as a no-op until 10.x becomes End-of-Life.

I’d prefer to keep the flag indefinitely. There’s no reason not to.

or @addaleax would we consider taking workers out of experimental for 10.x before it goes into maintenance in April?

I, personally, don’t have any plans to do so (and, admittedly, no overview over what changes would have to be backported to v10.x for this to happen), so I’m guessing not? @nodejs/workers

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making my -1 explicit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants