Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: remove undocumented now argument from emitWarning() #31643

Merged
merged 1 commit into from
Feb 8, 2020

Commits on Feb 8, 2020

  1. process: remove undocumented now argument from emitWarning()

    process.emitWarning() "now" option is undocumented and a Boolean trap.
    Remove it before people start adopting it.
    
    We only need it in one place internally. Replace it with an
    internal-only emitWarningSync() function.
    
    PR-URL: nodejs#31643
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Trott committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    8c18e91 View commit details
    Browse the repository at this point in the history