Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update security release process #31679

Closed

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Feb 7, 2020

Checklist

@sam-github sam-github force-pushed the update-sec-release-process branch from 2861c59 to a475317 Compare February 7, 2020 19:26
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 7, 2020
doc/guides/security_release_process.md Outdated Show resolved Hide resolved
doc/guides/security_release_process.md Outdated Show resolved Hide resolved
@sam-github
Copy link
Contributor Author

sam-github commented Feb 7, 2020

@nodejs/docker Updating docker is a moderately complex process, and has been done by the docker team for the last two sec releases (rather than me, thanks!). Example: nodejs/docker-node#1209

I formalized this here. I added a step to open an issue in docker-node to notify the team of the upcoming sec release, the issue can then be closed when you PR the update. But perhaps I can remove those two steps, since you already watch the sec release announcement list, and you were already doing the integration by the time I got to the repo to kick off the process?

EDIT - also, I deleted a bunch of docker release process instructions, assuming that your team doesn't need them because its what you do all the time, but correct me if I'm wrong and those docs do need to go somewhere.

@sam-github sam-github force-pushed the update-sec-release-process branch from a475317 to 4392e4b Compare February 13, 2020 17:30
@sam-github sam-github force-pushed the update-sec-release-process branch from 4392e4b to ff70344 Compare February 14, 2020 17:14
@sam-github sam-github force-pushed the update-sec-release-process branch 3 times, most recently from 125d6b7 to e2d2d3b Compare February 24, 2020 18:47
@sam-github sam-github marked this pull request as ready for review February 24, 2020 18:47
@sam-github sam-github force-pushed the update-sec-release-process branch 3 times, most recently from cc7d25d to 7eb0f30 Compare March 12, 2020 16:45
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github sam-github force-pushed the update-sec-release-process branch from 7eb0f30 to 788f8e6 Compare March 12, 2020 20:11
@mhdawson
Copy link
Member

Doc, only so not CI run required, only passing Travis job which is green. Landing.

mhdawson pushed a commit that referenced this pull request Mar 19, 2020
PR-URL: #31679
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@mhdawson
Copy link
Member

Landed in f7771ff

@mhdawson mhdawson closed this Mar 19, 2020
@sam-github sam-github deleted the update-sec-release-process branch March 20, 2020 18:14
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
PR-URL: #31679
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
targos pushed a commit that referenced this pull request Apr 22, 2020
PR-URL: #31679
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants