-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update security release process #31679
Conversation
2861c59
to
a475317
Compare
@nodejs/docker Updating docker is a moderately complex process, and has been done by the docker team for the last two sec releases (rather than me, thanks!). Example: nodejs/docker-node#1209 I formalized this here. I added a step to open an issue in docker-node to notify the team of the upcoming sec release, the issue can then be closed when you PR the update. But perhaps I can remove those two steps, since you already watch the sec release announcement list, and you were already doing the integration by the time I got to the repo to kick off the process? EDIT - also, I deleted a bunch of docker release process instructions, assuming that your team doesn't need them because its what you do all the time, but correct me if I'm wrong and those docs do need to go somewhere. |
a475317
to
4392e4b
Compare
4392e4b
to
ff70344
Compare
125d6b7
to
e2d2d3b
Compare
cc7d25d
to
7eb0f30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7eb0f30
to
788f8e6
Compare
Doc, only so not CI run required, only passing Travis job which is green. Landing. |
PR-URL: #31679 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Landed in f7771ff |
PR-URL: #31679 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #31679 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Checklist