doc: revise deepEqual() legacy assertion mode text #31704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
BridgeAR
approved these changes
Feb 9, 2020
BridgeAR
added
the
author ready
cjihrig
approved these changes
Feb 9, 2020
jasnell
approved these changes
Feb 10, 2020
* Remove "potentially". It's arguably misplaced and certainly unnecessary. * Use italics for words-as-words usage of _Deep equality_ rather than using quotation marks. PR-URL: nodejs#31704 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
force-pushed
the
assert-cleanup
branch
from
2613aa1 to
8d8f7c6
Compare
|
Landed in 8d8f7c6 |
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
* Remove "potentially". It's arguably misplaced and certainly unnecessary. * Use italics for words-as-words usage of _Deep equality_ rather than using quotation marks. PR-URL: #31704 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
* Remove "potentially". It's arguably misplaced and certainly unnecessary. * Use italics for words-as-words usage of _Deep equality_ rather than using quotation marks. PR-URL: #31704 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
* Remove "potentially". It's arguably misplaced and certainly unnecessary. * Use italics for words-as-words usage of _Deep equality_ rather than using quotation marks. PR-URL: #31704 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
* Remove "potentially". It's arguably misplaced and certainly unnecessary. * Use italics for words-as-words usage of _Deep equality_ rather than using quotation marks. PR-URL: #31704 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using quotation marks.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes