test: add known issues test for #31733 #31734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nodejs/crypto |
cjihrig
approved these changes
Feb 11, 2020
jasnell
added
the
known limitation
jasnell
approved these changes
Feb 11, 2020
|
@mcollina ... it's possible that this issue is caused by a timing issue in streams. |
addaleax
added
author ready
|
I don't know what can cause this. What's not clear is if this is a regression or not. |
|
The error comes from cpp land https://github.com/nodejs/node/blob/master/src/node_crypto.cc#L4574. |
addaleax
reviewed
Feb 13, 2020
addaleax
removed
the
author ready
Authenticated decryption works for file streams up to 32768 bytes but not beyond. Other streams and direct decryption are not affected. Refs: nodejs#31733
bnoordhuis
added
the
author ready
Trott
reviewed
Feb 21, 2020
| @@ -0,0 +1,142 @@ | |||
| /* eslint-disable node-core/crypto-check */ | |||
There was a problem hiding this comment.
Might not be a bad idea to create a test/known_issues/.eslintrc.yaml and disable the lint rule there, but also probably outside the scope of this PR.
|
Landed in 6f94221 |
addaleax
pushed a commit
that referenced
this pull request
Apr 2, 2020
Authenticated decryption works for file streams up to 32768 bytes but not beyond. Other streams and direct decryption are not affected. Refs: #31733 PR-URL: #31734 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
I'm seeing this failing on #32521, not sure if it's flaky or that PR broke something. |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
Authenticated decryption works for file streams up to 32768 bytes but not beyond. Other streams and direct decryption are not affected. Refs: #31733 PR-URL: #31734 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Authenticated decryption works for file streams up to 32768 bytes but not beyond. Other streams and direct decryption are not affected. Refs: #31733 PR-URL: #31734 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Authenticated decryption works for file streams up to 32768 bytes but not beyond. Other streams and direct decryption are not affected. Refs: #31733 PR-URL: #31734 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authenticated decryption works for file streams up to 32768 bytes but
not beyond. Other streams and direct decryption are not affected.
Refs: #31733