Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: move eljefedelrodeodeljefe to emeritus #31735

Closed
wants to merge 0 commits into from
Closed

meta: move eljefedelrodeodeljefe to emeritus #31735

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 11, 2020

eljefedelrodeodeljefe confirmed in email that moving to emeritus was
fine at this time.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 11, 2020
@Trott
Copy link
Member Author

Trott commented Feb 11, 2020

@eljefedelrodeodeljefe

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 11, 2020
@addaleax
Copy link
Member

@Trott This needs a rebase :)

Trott added a commit to Trott/io.js that referenced this pull request Feb 19, 2020
@Trott
meta: move eljefedelrodeodeljefe to emeritus
822101f 
eljefedelrodeodeljefe confirmed in email that moving to emeritus was
fine at this time.

PR-URL: nodejs#31735
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Trott Trott closed this Feb 19, 2020
@Trott
Copy link
Member Author

Trott commented Feb 19, 2020

Landed in 822101f

@Trott Trott deleted the emeritus-3 branch February 19, 2020 04:02
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@Trott @codebytere
meta: move eljefedelrodeodeljefe to emeritus
94a471a 
eljefedelrodeodeljefe confirmed in email that moving to emeritus was
fine at this time.

PR-URL: #31735
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
meta: move eljefedelrodeodeljefe to emeritus
59c75e5 
eljefedelrodeodeljefe confirmed in email that moving to emeritus was
fine at this time.

PR-URL: #31735
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
meta: move eljefedelrodeodeljefe to emeritus
f9b4a86 
eljefedelrodeodeljefe confirmed in email that moving to emeritus was
fine at this time.

PR-URL: #31735
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
meta: move eljefedelrodeodeljefe to emeritus
2a4d31a 
eljefedelrodeodeljefe confirmed in email that moving to emeritus was
fine at this time.

PR-URL: #31735
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @addaleax @jasnell @lpinca @targos @cjihrig @gireeshpunathil @BridgeAR @nodejs-github-bot