net: autoDestroy Socket #31806

ronag · 2020-02-15T00:57:20Z

Refactors net.Socket into using autoDestroy functionality of streams.

~~During this refactoring due to slightly different timing of things other bugs got activated and needed to be resolved.~~

~~Also, the behaviour of net.Socket and stream.Duplex needed to be consolidated to have the same generic behaviour in terms of allowHalfOpen.~~

~~Also fixes a close vs shutdown race #32486 (comment)~~

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2020-02-15T00:58:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29143/

nodejs-github-bot · 2020-02-15T01:25:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29145/

ronag · 2020-02-15T01:35:10Z

If backporting autoDestroy would have to be explicitly set to true.

mcollina

lgtm

mcollina · 2020-02-15T08:04:46Z

I prefer this to land as a semver-major commit.

nodejs-github-bot · 2020-02-15T11:22:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29150/

nodejs-github-bot · 2020-02-16T09:14:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29164/

ronag · 2020-04-02T12:37:33Z

Nevermind, CITGM looks good. This PR actually has fever failures than master (for some reason?).

mcollina · 2020-04-02T12:40:09Z

@nodejs/tsc this needs another approval.

addaleax · 2020-04-02T16:05:50Z

test/parallel/test-http2-max-invalid-frames.js

+  const conn = net.connect({
+    port: server.address().port,
+    allowHalfOpen: true
+  });


I’m not sure I understand why this is necessary either, but I agree that the test functionality shouldn’t be affected – the important thing is that the .once('error') handler below fires.

ronag · 2020-04-02T21:38:47Z

Landed in efefdd6

Refactors net.Socket into using autoDestroy functionality of streams. PR-URL: #31806 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Writable stream could emit 'finish' after 'close'. PR-URL: #32933 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Set `allowHalfOpen: true` in the client. Fixes: nodejs#29802 Refs: nodejs#31806

Set `allowHalfOpen: true` in the client. Fixes: #29802 Refs: #31806 PR-URL: #34318 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Nagy <ronagy@icloud.com>

Notable changes: Deprecations and Removals: - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **timers**: introduce timers/promises (James M Snell) (#33950) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) npm 7 (#35631): Node.js 15 comes with a new major release of npm, npm 7. npm 7 comes with many new features - including npm workspaces and a new package-lock.json format. npm 7 also includes yarn.lock file support. One of the big changes in npm 7 is that peer dependencies are now installed by default. Throw On Unhandled Rejections (#33021): As of Node.js 15, the default mode for `unhandledRejection` is changed to `throw` (from `warn`). In `throw` mode, if an `unhandledRejection` hook is not set, the `unhandledRejection` is raised as an uncaught exception. Users that have an `unhandledRejection` hook should see no change in behavior, and it’s still possible to switch modes using the `--unhandled-rejections=mode` process flag. QUIC (#32379): Node.js 15 comes with experimental support QUIC, which can be enabled by compiling Node.js with the `--experimental-quic` configuration flag. The Node.js QUIC implementation is exposed by the core `net` module. V8 8.6 (#35415): The V8 JavaScript engine has been updated to V8 8.6 (V8 8.4 is the latest available in Node.js 14). Along with performance tweaks and improvements the V8 update also brings the following language features: * `Promise.any()` (from V8 8.5) * `AggregateError` (from V8 8.5) * `String.prototype.replaceAll()` (from V8 8.5) * Logical assignment operators `&&=`, `||=`, and `??=` (from V8 8.5) Other Notable Changes: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **dns**: add dns/promises alias (shisama) (#32953) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **stream**: construct (Robert Nagy) (#29656) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) Semver-Major Commits: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **build**: reset embedder string to "-node.0" (Michaël Zasso) (#35415) - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **crypto**: refactoring internals, add WebCrypto (James M Snell) (#35093) - **crypto**: move node\_crypto files to src/crypto (James M Snell) (#35093) - **deps**: V8: cherry-pick d76abfed3512 (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 717543bbf0ef (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 6be2f6e26e8d (Michaël Zasso) (#35415) - **deps**: fix V8 build issue with inline methods (Jiawen Geng) (#35415) - **deps**: fix platform-embedded-file-writer-win for ARM64 (Michaël Zasso) (#35415) - **deps**: update V8 postmortem metadata script (Colin Ihrig) (#35415) - **deps**: update V8 to 8.6.395 (Michaël Zasso) (#35415) - **deps**: upgrade npm to 7.0.0 (Myles Borins) (#35631) - **deps**: update npm to 7.0.0-rc.3 (Myles Borins) (#35474) - **deps**: V8: cherry-pick 0d6debcc5f08 (Gus Caplan) (#33600) - **dns**: add dns/promises alias (shisama) (#32953) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **doc**: update support macos version for 15.x (Ash Cripps) (#35022) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http**: fixed socket.setEncoding fatal error (iskore) (#33405) - **http**: emit 'error' on aborted server request (Robert Nagy) (#33172) - **http**: cleanup end argument handling (Robert Nagy) (#31818) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **http2**: add `invalidheaders` test (Pranshu Srivastava) (#33161) - **http2**: refactor state code validation for the http2Stream class (rickyes) (#33535) - **http2**: header field valid checks (Pranshu Srivastava) (#33193) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: remove ERR\_INVALID\_OPT\_VALUE and ERR\_INVALID\_OPT\_VALUE\_ENCODING (Denys Otrishko) (#34682) - **lib**: handle one of args case in ERR\_MISSING\_ARGS (Denys Otrishko) (#34022) - **lib**: remove NodeError from the prototype of errors with code (Michaël Zasso) (#33857) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: check args in net.connect() and socket.connect() calls (Denys Otrishko) (#34022) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **process**: update v8 fast api calls usage (Maya Lekova) (#35415) - **process**: change default --unhandled-rejections=throw (Dan Fabulich) (#33021) - **process**: use v8 fast api calls for hrtime (Gus Caplan) (#33600) - **process**: delay throwing an error using `throwDeprecation` (Ruben Bridgewater) (#32312) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: implement NodePlatform::PostJob (Clemens Backes) (#35415) - **src**: update NODE\_MODULE\_VERSION to 88 (Michaël Zasso) (#35415) - **src**: error reporting on CPUUsage (Yash Ladha) (#34762) - **src**: use node:moduleName as builtin module filename (Michaël Zasso) (#35498) - **src**: enable wasm trap handler on windows (Gus Caplan) (#35033) - **src**: update NODE\_MODULE\_VERSION to 86 (Michaël Zasso) (#33579) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **src**: remove \_third\_party\_main support (Anna Henningsen) (#33971) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **src**: remove unused CancelPendingDelayedTasks (Anna Henningsen) (#32859) - **stream**: try to wait for flush to complete before 'finish' (Robert Nagy) (#34314) - **stream**: cleanup and fix Readable.wrap (Robert Nagy) (#34204) - **stream**: add promises version to utility functions (rickyes) (#33991) - **stream**: fix writable.end callback behavior (Robert Nagy) (#34101) - **stream**: construct (Robert Nagy) (#29656) - **stream**: write should throw on unknown encoding (Robert Nagy) (#33075) - **stream**: fix \_final and 'prefinish' timing (Robert Nagy) (#32780) - **stream**: simplify Transform stream implementation (Robert Nagy) (#32763) - **stream**: use callback to properly propagate error (Robert Nagy) (#29179) - **test**: update tests after increasing typed array size to 4GB (Kim-Anh Tran) (#35415) - **test**: fix tests for npm 7.0.0 (Myles Borins) (#35631) - **test**: fix test suite to work with npm 7 (Myles Borins) (#35474) - **test**: update WPT harness and tests (Michaël Zasso) (#33770) - **timers**: introduce timers/promises (James M Snell) (#33950) - **tools**: disable x86 safe exception handlers in V8 (Michaël Zasso) (#35415) - **tools**: update V8 gypfiles for 8.6 (Ujjwal Sharma) (#35415) - **tools**: update V8 gypfiles for 8.5 (Ujjwal Sharma) (#35415) - **url**: file URL path normalization (Daijiro Wachi) (#35477) - **url**: verify domain is not empty after "ToASCII" (Michaël Zasso) (#33770) - **url**: remove U+0000 case in the fragment state (Michaël Zasso) (#33770) - **url**: remove gopher from special schemes (Michaël Zasso) (#33325) - **url**: forbid lt and gt in url host code point (Yash Ladha) (#33328) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) - **win, child_process**: sanitize env variables (Bartosz Sosnowski) (#35210) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) - **worker**: set trackUnmanagedFds to true by default (Anna Henningsen) (#34394) - **worker**: rename error code to be more accurate (Anna Henningsen) (#33872) PR-URL: #35014

ronag added net Issues and PRs related to the net subsystem. stream Issues and PRs related to the stream subsystem. labels Feb 15, 2020

ronag requested review from mcollina, jasnell and addaleax February 15, 2020 00:57

ronag force-pushed the net-use-autodestroy branch from 0117c05 to daabdb1 Compare February 15, 2020 01:23

ronag added dont-land-on-v10.x labels Feb 15, 2020

mcollina added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 15, 2020

mcollina approved these changes Feb 15, 2020

View reviewed changes

ronag removed dont-land-on-v10.x labels Feb 15, 2020

addaleax approved these changes Feb 15, 2020

View reviewed changes

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 15, 2020

lpinca previously approved these changes Feb 16, 2020

View reviewed changes

lundibundi approved these changes Feb 16, 2020

View reviewed changes

ronag added dont-land-on-v10.x and removed dont-land-on-v10.x labels Feb 16, 2020

addaleax approved these changes Apr 2, 2020

View reviewed changes

ronag closed this Apr 2, 2020

This was referenced Apr 12, 2020

stream: fix _final and 'prefinish' timing #32780

Closed

test: add net regression test #32794

Closed

ronag mentioned this pull request Apr 20, 2020

stream: ensure pipeline always destroys streams #31940

Closed

4 tasks

ronag referenced this pull request Apr 28, 2020

stream: don't emit finish after close

3c07b17

Writable stream could emit 'finish' after 'close'. PR-URL: #32933 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

ronag mentioned this pull request Apr 28, 2020

test: ensure finish is emitted before destroy #33137

Closed

4 tasks

Trott mentioned this pull request Jul 12, 2020

flaky test-http2-reset-flood #29802

Closed

Trott added a commit to Trott/io.js that referenced this pull request Jul 12, 2020

test: fix flaky test-http2-reset-flood

9e95a46

Set `allowHalfOpen: true` in the client. Fixes: nodejs#29802 Refs: nodejs#31806

Trott mentioned this pull request Jul 12, 2020

test: fix flaky test-http2-reset-flood #34318

Closed

2 tasks

BethGriggs mentioned this pull request Sep 1, 2020

2020-10-20, Version 15.0.0 (Current) #35014

Merged

flotwig mentioned this pull request Nov 9, 2021

feat(deps): update dependency electron to v15 🌟 cypress-io/cypress#18317

Merged

This was referenced Jul 5, 2022

Lazy socket unable to reconnect on abruptly terminated connections on Node 16 felixge/node-lazy-socket#3

Closed

'error' event no longer emitted for net connections #43724

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: autoDestroy Socket #31806

net: autoDestroy Socket #31806

ronag commented Feb 15, 2020 •

edited

Loading

nodejs-github-bot commented Feb 15, 2020

nodejs-github-bot commented Feb 15, 2020

ronag commented Feb 15, 2020

mcollina left a comment

mcollina commented Feb 15, 2020

nodejs-github-bot commented Feb 15, 2020

nodejs-github-bot commented Feb 16, 2020

ronag commented Apr 2, 2020

mcollina commented Apr 2, 2020

addaleax Apr 2, 2020

ronag commented Apr 2, 2020

net: autoDestroy Socket #31806

net: autoDestroy Socket #31806

Conversation

ronag commented Feb 15, 2020 • edited Loading

Checklist

nodejs-github-bot commented Feb 15, 2020

nodejs-github-bot commented Feb 15, 2020

ronag commented Feb 15, 2020

mcollina left a comment

Choose a reason for hiding this comment

mcollina commented Feb 15, 2020

nodejs-github-bot commented Feb 15, 2020

nodejs-github-bot commented Feb 16, 2020

ronag commented Apr 2, 2020

mcollina commented Apr 2, 2020

addaleax Apr 2, 2020

Choose a reason for hiding this comment

ronag commented Apr 2, 2020

ronag commented Feb 15, 2020 •

edited

Loading