test: update WPT harness

[targos]

/cc @joyeecheung there's a problem with the new assert_throws_js function. It now checks error.constructor === constructor. This doesn't work with Node's errors because they extend the native ones so we end up with checks like NodeError === TypeError. What can we do here?

Example:

assert_throws_js: no argument function "() => queueMicrotask()" threw object "TypeError [ERR_INVALID_ARG_TYPE]: The "callback" argument must be of type function. Received undefined" ("TypeError") expected instance of function "function TypeError() { [native code] }" ("TypeError")
    at Test.<anonymous> (/home/mzasso/git/nodejs/node/test/fixtures/wpt/html/webappapis/microtask-queuing/queue-microtask.any.js:9:3)
    at Test.step (/home/mzasso/git/nodejs/node/test/fixtures/wpt/resources/testharness.js:1977:25)
    at test (/home/mzasso/git/nodejs/node/test/fixtures/wpt/resources/testharness.js:535:30)
    at /home/mzasso/git/nodejs/node/test/fixtures/wpt/html/webappapis/microtask-queuing/queue-microtask.any.js:8:1
    at Script.runInContext (vm.js:141:18)

[targos]

ping @joyeecheung

[targos]

@nodejs/testing

[Trott]

Radical idea: We could get rid of NodeError, or at least get rid of NodeError for errors that are the result of Web Platform compatibility.

/ping @addaleax

[addaleax]

@Trott I don’t think that would be a bad thing, yes – since there is no single NodeError class but rather hundreds of them, I don’t think they provide any specific value to users.

[joyeecheung]

Or maybe we can have a flag to use vanilla errors when we throw in Web APIs (I thought about this but it would involve quite a few updates to the Web API code, especially considering we lint for these...).

[targos]

I propose to use vanilla errors everywhere with #33857

[targos]

Okay, now everything is updated and python tools/test.py wpt passes. There are failing parallel tests though and, at least for url, they require us to fix our implementation. This cannot be done in a separate PR because the refactoring of the WPT harness happened after the changes of the tests.

=== release test-icu-punycode ===                                             
Path: parallel/test-icu-punycode
assert.js:103
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: ToASCII case 36
    at Object.<anonymous> (/home/mzasso/git/nodejs/node/test/parallel/test-icu-punycode.js:54:14)
    at Module._compile (internal/modules/cjs/loader.js:1089:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1110:10)
    at Module.load (internal/modules/cjs/loader.js:954:32)
    at Function.Module._load (internal/modules/cjs/loader.js:795:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47 {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: 'a%c2%adb',
  expected: 'ab',
  operator: 'strictEqual'
}
Command: out/Release/node --expose-internals /home/mzasso/git/nodejs/node/test/parallel/test-icu-punycode.js
=== release test-whatwg-url-constructor ===                                   
Path: parallel/test-whatwg-url-constructor
In Parsing: <http://example.org/test?a#bc> against <about:blank>:
/home/mzasso/git/nodejs/node/test/common/wpt.js:21
      throw err;
      ^

AssertionError [ERR_ASSERTION]: href
    at /home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-constructor.js:58:7
    at test (/home/mzasso/git/nodejs/node/test/common/wpt.js:18:7)
    at runURLTests (/home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-constructor.js:49:5)
    at runURLConstructorTests (/home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-constructor.js:33:10)
    at Object.<anonymous> (/home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-constructor.js:144:1)
    at Module._compile (internal/modules/cjs/loader.js:1089:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1110:10)
    at Module.load (internal/modules/cjs/loader.js:954:32)
    at Function.Module._load (internal/modules/cjs/loader.js:795:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: 'http://example.org/test?a#bc',
  expected: 'http://example.org/test?a#b%00c',
  operator: 'strictEqual'
}
Command: out/Release/node /home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-constructor.js
=== release test-whatwg-url-custom-parsing ===                                
Path: parallel/test-whatwg-url-custom-parsing
assert.js:103
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Missing expected exception.
    at Object.<anonymous> (/home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-custom-parsing.js:55:10)
    at Module._compile (internal/modules/cjs/loader.js:1089:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1110:10)
    at Module.load (internal/modules/cjs/loader.js:954:32)
    at Function.Module._load (internal/modules/cjs/loader.js:795:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47 {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: undefined,
  expected: [Function (anonymous)],
  operator: 'throws'
}
Command: out/Release/node /home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-custom-parsing.js
=== release test-whatwg-url-toascii ===                                       
Path: parallel/test-whatwg-url-toascii
In ­ (using URL):
/home/mzasso/git/nodejs/node/test/common/wpt.js:21
      throw err;
      ^

AssertionError [ERR_ASSERTION]: Missing expected exception.
    at assert_throws (/home/mzasso/git/nodejs/node/test/common/wpt.js:28:12)
    at /home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-toascii.js:63:13
    at test (/home/mzasso/git/nodejs/node/test/common/wpt.js:18:7)
    at /home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-toascii.js:54:7
    at Array.forEach (<anonymous>)
    at runTests (/home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-toascii.js:53:14)
    at Object.<anonymous> (/home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-toascii.js:30:5)
    at Module._compile (internal/modules/cjs/loader.js:1089:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1110:10)
    at Module.load (internal/modules/cjs/loader.js:954:32) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: undefined,
  expected: [Function (anonymous)],
  operator: 'throws'
}
Command: out/Release/node /home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-toascii.js
=== release test-whatwg-url-setters ===                                  
Path: parallel/test-whatwg-url-setters
In URL: Setting <a:/>.hash = '

 !"#$%&'()*+,-./09:;<=>?@AZ[\]^_`az{|}~Éé' Simple percent-encoding; tabs and newlines are removed:
/home/mzasso/git/nodejs/node/test/common/wpt.js:21
      throw err;
      ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ "a:/#%01%1F%20!%22#$%&'()*+,-./09:;%3C=%3E?@AZ[\\]^_%60az{|}~%7F%C2%80%C2%81%C3%89%C3%A9"
- "a:/#%00%01%1F%20!%22#$%&'()*+,-./09:;%3C=%3E?@AZ[\\]^_%60az{|}~%7F%C2%80%C2%81%C3%89%C3%A9"
    at /home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-setters.js:56:11
    at test (/home/mzasso/git/nodejs/node/test/common/wpt.js:18:7)
    at runURLSettersTests (/home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-setters.js:52:7)
    at startURLSettersTests (/home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-setters.js:33:10)
    at Object.<anonymous> (/home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-setters.js:79:1)
    at Module._compile (internal/modules/cjs/loader.js:1089:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1110:10)
    at Module.load (internal/modules/cjs/loader.js:954:32)
    at Function.Module._load (internal/modules/cjs/loader.js:795:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: "a:/#%01%1F%20!%22#$%&'()*+,-./09:;%3C=%3E?@AZ[\\]^_%60az{|}~%7F%C2%80%C2%81%C3%89%C3%A9",
  expected: "a:/#%00%01%1F%20!%22#$%&'()*+,-./09:;%3C=%3E?@AZ[\\]^_%60az{|}~%7F%C2%80%C2%81%C3%89%C3%A9",
  operator: 'strictEqual'
}
Command: out/Release/node /home/mzasso/git/nodejs/node/test/parallel/test-whatwg-url-setters.js
[02:02|% 100|+ 3149|-   5]: Done                                              
make[1]: *** [Makefile:299: jstest] Error 1
make: *** [Makefile:325: test] Error 2

[targos]

Happy to get some help investigating the issues. I won't have much more time for it this week.

[Trott]

Not sure if this superficial info is helpful, but since no one else has commented: test-icu-punycode is failing because of changes to test/fixtures/wpt/url/resources/toascii.json and I'm going to guess that the rest of the tests are failing because of fixtures changes too.

[watilde]

I'm fixing the same issue and turned out that test/parallel/test-icu-punyucode.js depends on the same fixture of require('url').domainToASCII which is test/fixtures/wpt/url/resources/toascii.json and this happens. I'm wondering if we should update ICU's logic to follow whatwg's domainToASCII updates or separate the test cases for the two ICU's toASCII & URL's domainToASCII as it has a few small differences

e.g.
https://github.com/jsdom/whatwg-url/blob/master/src/url-state-machine.js#L419-L421

My hypothetical process for the next step is the below:

1. Separate the test cases between ICU's toASCII and URL's domainToASCII
2. Update URL parser to pass all of the latest WPT's test cases
3. Design test cases for ICU's toASCII
4. Follow the latest logic of ICU's toASCII spec

[Leko]

@targos I tried to investigate this case:

AssertionError [ERR_ASSERTION]: ToASCII case 36
...
actual: 'a%c2%adb',
expected: 'ab',

%c2%ad is soft hyphen and it's an ignored code point in IDNA spec. The ignored code point should be replaced with empty character.
URL's domainToASCII handles percent-encoded soft hyphen correctly, but ICU's toASCII can't handle it.

> require('url').domainToASCII('a%c2%adb')
'ab'
> require('internal/test/binding').internalBinding('icu').toASCII('a%c2%adb')
'a%c2%adb'

We should fix ICU's toASCII to fix the failing case in test/parallel/test-icu-punycode.js. Specifically, we need to add these processes to ICU's toASCII.

• percent decode
• throw an exception when the string was empty

Anyway, it's ICU's problem, not the WPT URL problem. I think we should break the problem down into smaller pieces as @watilde suggested.

[targos]

I pushed ports of whatwg/url#486 and whatwg/url#497
Now only test-icu-punycode fails and IIUC, #35077 fixes it.

[github-actions]

Landed in 9cf9e4a...69ef4c2