Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify http2.connect authority #31828

Closed
wants to merge 2 commits into from
Closed

doc: clarify http2.connect authority #31828

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 17, 2020

Clarify http2.connect authority parameter details

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Feb 17, 2020
@jasnell jasnell mentioned this pull request Feb 17, 2020
Closed
szmarczak
szmarczak suggested changes Feb 17, 2020
View reviewed changes
doc/api/http2.md
@@ -2206,7 +2206,10 @@ changes:
128 header pairs.
-->

* `authority` {string|URL}
* `authority` {string|URL} The remote HTTP/2 server to connect to. This must

This comment was marked as resolved.

Sign in to view

@szmarczak
Copy link
Member

szmarczak commented Feb 17, 2020 •
edited
Loading

I think I've already pointed out that the word authority is incorrectly used here, so redefining the meaning for Node.js won't change the RFC definition.

@jasnell
Copy link
Member Author

jasnell commented Feb 17, 2020

I'll look at changing to authority to origin in a separate PR. I want to go back and check what the name of the argument is in the source and change it there also if necessary to keep them in sync, just don't have the opportunity to do so yet.

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 24, 2020
jasnell
jasnell commented Feb 26, 2020
View reviewed changes
doc/api/http2.md Outdated Show resolved Hide resolved
@jasnell
Copy link
Member Author

jasnell commented Feb 26, 2020

CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4134/

jasnell added a commit that referenced this pull request Feb 27, 2020
@jasnell
doc: clarify http2.connect authority details
cbaae7a 
Fixes: #31827

PR-URL: #31828
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Feb 27, 2020

Landed in cbaae7a

@jasnell jasnell closed this Feb 27, 2020
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@jasnell @codebytere
doc: clarify http2.connect authority details
8516602 
Fixes: #31827

PR-URL: #31828
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@jasnell @codebytere
doc: clarify http2.connect authority details
dc745e3 
Fixes: #31827

PR-URL: #31828
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@jasnell @codebytere
doc: clarify http2.connect authority details
ce1c681 
Fixes: #31827

PR-URL: #31828
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@jasnell @codebytere
doc: clarify http2.connect authority details
a1c0d46 
Fixes: #31827

PR-URL: #31828
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmarczak szmarczak szmarczak approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @szmarczak @lpinca @cjihrig @ZYSzys @nodejs-github-bot