Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix notable changes for v13.9.0 #31857

Closed
wants to merge 1 commit into from
Closed

doc: fix notable changes for v13.9.0 #31857

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

Fixes Notable Changes for v13.9.0. They're correct in the release commit and in the blog post, but I whiffed on them here.

cc @BethGriggs

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@codebytere codebytere added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 18, 2020
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 18, 2020
MylesBorins
MylesBorins approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

fast track?

@MylesBorins
Copy link
Contributor

Landed in 3129082

MylesBorins pushed a commit that referenced this pull request Feb 18, 2020
@codebytere @MylesBorins
doc: fix notable changes for v13.9.0
3129082 
PR-URL: #31857
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
codebytere added a commit that referenced this pull request Feb 27, 2020
@codebytere
doc: fix notable changes for v13.9.0
3438937 
PR-URL: #31857
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@tniessen tniessen tniessen approved these changes

@addaleax addaleax addaleax approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@codebytere @MylesBorins @addaleax @tniessen @BethGriggs @nodejs-github-bot