Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: allow unique_ptrs with custom deleter in memory tracker #31870

Closed
wants to merge 1 commit into from
Closed

src: allow unique_ptrs with custom deleter in memory tracker #31870

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 19, 2020

Authored by @addaleax and originally landed in the QUIC repo. Separating it out from the QUIC PR. This does not have any QUIC specific bits...

Original review metadata:

  PR-URL: https://github.com/nodejs/quic/pull/145
  Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax @jasnell
src: allow unique_ptrs with custom deleter in memory tracker
d1317d0 
Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#145
  Reviewed-By: James M Snell <jasnell@gmail.com>
```
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 19, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29246/

jasnell pushed a commit that referenced this pull request Feb 24, 2020
@addaleax @jasnell
src: allow unique_ptrs with custom deleter in memory tracker
e68d4c6 
Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#145
  Reviewed-By: James M Snell <jasnell@gmail.com>
```

PR-URL: #31870
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Feb 24, 2020

Landed in e68d4c6

@jasnell jasnell closed this Feb 24, 2020
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@addaleax @codebytere
src: allow unique_ptrs with custom deleter in memory tracker
8fa6373 
Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#145
  Reviewed-By: James M Snell <jasnell@gmail.com>
```

PR-URL: #31870
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@addaleax @codebytere
src: allow unique_ptrs with custom deleter in memory tracker
0403fcf 
Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#145
  Reviewed-By: James M Snell <jasnell@gmail.com>
```

PR-URL: #31870
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@addaleax @codebytere
src: allow unique_ptrs with custom deleter in memory tracker
f66627c 
Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#145
  Reviewed-By: James M Snell <jasnell@gmail.com>
```

PR-URL: #31870
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@addaleax @codebytere
src: allow unique_ptrs with custom deleter in memory tracker
3b2bbbd 
Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#145
  Reviewed-By: James M Snell <jasnell@gmail.com>
```

PR-URL: #31870
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lundibundi lundibundi lundibundi approved these changes

@devnexen devnexen devnexen approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasnell @nodejs-github-bot @addaleax @cjihrig @joyeecheung @devnexen @lundibundi