Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: implement per-process native Debug() printer and use it in mkcodecache #31884
src: implement per-process native Debug() printer and use it in mkcodecache #31884
Changes from 4 commits
4439730
2b80488
ce2d7fe
9abbce6
c7c01d0
d86480a
de4b6c7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason that this would need to be a pointer? I don’t think that’s necessary, and it comes with one additional layer of indirection for each debug check. One of the goals for the Debug() implementation was to have as close to zero overhead as possible, and I think this might get in the way of it…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly to avoid the circular dependency - but I guess this can also be achieved by moving more things from
debug_utils.h
todebug_utils-inl.h
so thatenv.h
can just includedebug_utils.h
anddebug_utils.h
do not need to includeenv.h
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that works, then that would be great – otherwise we might need to move more things into
env.h
…There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, looks like if we want to keep the initialization in the constructor, then it needs to be a pointer since we'd need the environment pointer with initialized env_vars for
credentials::SafeGetenv()
. So I just moved the initialization intoEnableDebugList::Parse()
, and call it inInitializeOncePerProcess
(and separately, in mkcodecache since it does not needInitializeOncePerProcess()
), this also means that for now the printer is not usable untilnode::Start()
is called in the default binary, but I guess that's fine, compared to reordering the whole initialization sequence to work around pointers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fwiw, what I had in mind is to use the trivial copy constructor to re-initialize it later, e.g.
enabled_debug_list_ = EnabledDebugList(...);
, but I guess::Parse()
works just as well :)