repl: eager-evaluate input in parens #31943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
approved these changes
Feb 25, 2020
jasnell
approved these changes
Feb 25, 2020
BridgeAR
reviewed
Feb 25, 2020
codebytere
force-pushed
the
fix-repl-eval-issue
branch
from
2bba06c
to
8098e49
Compare
codebytere
force-pushed
the
fix-repl-eval-issue
branch
from
8098e49
to
e39244e
Compare
BridgeAR
approved these changes
Feb 26, 2020
|
Landed in 20a51b9 |
codebytere
added a commit
that referenced
this pull request
Feb 27, 2020
PR-URL: #31943 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere
added a commit
that referenced
this pull request
Feb 27, 2020
PR-URL: #31943 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Feb 27, 2020
Merged
|
depends on the repl preview changes to land on v12.x |
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
PR-URL: nodejs#31943 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #31943 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #31820.
This PR updates repl evaluation to eagerly wrap all input in parentheses and adds a regression test using the example given in the above issue. I plan to open a follow-up PR to allow the preview to evaluate the code again unwrapped if the first attempt fails.
cc @BridgeAR @devsnek
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes