Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: fix socket re-use races #32000

Closed
wants to merge 3 commits into from

Commits on Feb 28, 2020

  1. http: fix socket re-use races

    Whether and when a socket is destroyed or not after a timeout is up to
    the user. This leaves an edge case where a socket that has emitted
    'timeout' might be re-used from the free pool. Even if destroy is called
    on the socket, it won't be removed from the freelist until 'close' which
    can happen several ticks later.
    
    Sockets are removed from the free list on the 'close' event.
    However, there is a delay between calling destroy() and 'close'
    being emitted. This means that it possible for a socket that has
    been destroyed to be re-used from the free list, causing unexpected
    failures.
    ronag committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    09e3863 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2020

  1. fixup: add doc note

    ronag committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    ff470e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2020

  1. fixup: nits

    ronag committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    594e55d View commit details
    Browse the repository at this point in the history