Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve Buffer documentation #32086

Closed
wants to merge 3 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Mar 4, 2020

Various improvements to the Buffer docs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Various improvements to the Buffer docs.
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Mar 4, 2020
@addaleax
Copy link
Member Author

addaleax commented Mar 7, 2020

@jasnell I’ve updated this based on feedback I’ve received in private, feel free to take another look :)

@addaleax
Copy link
Member Author

@nodejs/documentation

@jasnell
Copy link
Member

jasnell commented Mar 10, 2020

Still LGTM

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2020
@addaleax
Copy link
Member Author

Landed in c41e360

@addaleax addaleax closed this Mar 11, 2020
addaleax added a commit that referenced this pull request Mar 11, 2020
Various improvements to the Buffer docs.

PR-URL: #32086
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax deleted the buffer-doc-rewrite branch March 11, 2020 16:07
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
Various improvements to the Buffer docs.

PR-URL: #32086
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 12, 2020
targos pushed a commit that referenced this pull request Apr 22, 2020
Various improvements to the Buffer docs.

PR-URL: #32086
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants